Re: Review Request 26826: OOZIE-1931 Admin command to print all locks held by server(s)

[Jaydeep Vishwakarma <ja...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26826/#review94398
-----------------------------------------------------------



client/src/main/java/org/apache/oozie/cli/HAJsonParser.java (line 44)
<https://reviews.apache.org/r/26826/#comment148982>

    You can avoid to add this "if (length == 0)" , else case statement can handle this.



client/src/main/java/org/apache/oozie/cli/HAJsonParser.java (line 57)
<https://reviews.apache.org/r/26826/#comment148983>

    you dont need to check the size, It will work without condition.



client/src/main/java/org/apache/oozie/cli/HAJsonParser.java (line 86)
<https://reviews.apache.org/r/26826/#comment148984>

    you dont need if statement. write(String.valueOf(object), indent, bf); is good enough.



client/src/main/java/org/apache/oozie/cli/OozieCLI.java (line 1618)
<https://reviews.apache.org/r/26826/#comment148985>

    remove this line



client/src/test/java/org/apache/oozie/cli/TestHAJsonParser.java (line 63)
<https://reviews.apache.org/r/26826/#comment148986>

    this test case can very easily failed by mistake. I think we should remove empty space from both side and compare.



client/src/test/java/org/apache/oozie/cli/TestHAJsonParser.java (line 84)
<https://reviews.apache.org/r/26826/#comment148987>

    same here



core/src/main/java/org/apache/oozie/servlet/V2AdminServlet.java (line 87)
<https://reviews.apache.org/r/26826/#comment149029>

    formating , add white space on string concatinate.



core/src/main/java/org/apache/oozie/servlet/V2AdminServlet.java (line 129)
<https://reviews.apache.org/r/26826/#comment149030>

    new line



core/src/test/java/org/apache/oozie/servlet/TestLocksDump.java (line 145)
<https://reviews.apache.org/r/26826/#comment149031>

    change it to locks3



core/src/test/java/org/apache/oozie/servlet/TestLocksDump.java (line 148)
<https://reviews.apache.org/r/26826/#comment149032>

    change it to locks3


- Jaydeep Vishwakarma


On Oct. 16, 2014, 11:57 p.m., Purshotam Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26826/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 11:57 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1931
>     https://issues.apache.org/jira/browse/OOZIE-1931
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> OOZIE-1931 Admin command to print all locks held by server(s)
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/oozie/cli/HAJsonParser.java e69de29 
>   client/src/main/java/org/apache/oozie/cli/OozieCLI.java f3ffd1f 
>   client/src/main/java/org/apache/oozie/client/OozieClient.java d6ff2d0 
>   client/src/main/java/org/apache/oozie/client/rest/JsonTags.java 8a86bf1 
>   client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 4b393c8 
>   client/src/test/java/org/apache/oozie/cli/TestHAJsonParser.java e69de29 
>   core/src/main/java/org/apache/oozie/ha/inputrequest/HARequest.java e69de29 
>   core/src/main/java/org/apache/oozie/ha/inputrequest/LockDumpHARequest.java e69de29 
>   core/src/main/java/org/apache/oozie/lock/MemoryLocks.java ee564b3 
>   core/src/main/java/org/apache/oozie/service/MemoryLocksService.java e3eccdb 
>   core/src/main/java/org/apache/oozie/service/ZKLocksService.java 36c00b9 
>   core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java 64d3f1f 
>   core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 4e9c224 
>   core/src/main/java/org/apache/oozie/servlet/V0AdminServlet.java fd573d5 
>   core/src/main/java/org/apache/oozie/servlet/V1AdminServlet.java 2383433 
>   core/src/main/java/org/apache/oozie/servlet/V2AdminServlet.java adaab76 
>   core/src/test/java/org/apache/oozie/ha/inputrequest/TestHAVersion.java e69de29 
>   core/src/test/java/org/apache/oozie/service/DummyV2AdminServlet.java 0e466fc 
>   core/src/test/java/org/apache/oozie/service/TestHAShareLibService.java d2ad881 
>   core/src/test/java/org/apache/oozie/servlet/TestLocksDump.java e69de29 
>   docs/src/site/twiki/DG_CommandLineTool.twiki c65acbd 
>   docs/src/site/twiki/WebServicesAPI.twiki 6f31240 
> 
> Diff: https://reviews.apache.org/r/26826/diff/
> 
> 
> Testing
> -------
> 
> UTC and manual testing
> 
> 
> Thanks,
> 
> Purshotam Shah
> 
>