You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by "mstefany (via GitHub)" <gi...@apache.org> on 2024/04/12 17:43:08 UTC

Re: [PR] feat: add serviceMonitor for apisix-gateway [apisix-helm-chart]

mstefany commented on PR #706:
URL: https://github.com/apache/apisix-helm-chart/pull/706#issuecomment-2052201576

   @AlinsRan @Revolyssup I updated the PR:
   
   - because both `apisix-ingress-controller` and `apisix` containers have ports named `http`, original `ServiceMonitor` would scrape both containers (if `apisix-gateway` is enabled), and cause error every 15 seconds, because there are no metrics on http port 9080 of gateway at `/metrics` URL. For this reason I am renaming `http` port of `apisix-gateway-controller` to `http-controller`.
   - enabling `ServiceMonitor` of gateway is now done separately in `.Values.gateway.serviceMonitor`, and it also provisions separate `ServiceMonitor` object to scrape such metrics
   
   Please, review the code if this approach is acceptable. I have updated `README.md` with `helm-docs` so there shouldn't be linter errors.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org