You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "tkobayas (via GitHub)" <gi...@apache.org> on 2025/04/22 09:23:36 UTC

[PR] [incubator-kie-drools-6314] Ability to use pseudo clock with rule uni… [incubator-kie-drools]

tkobayas opened a new pull request, #6319:
URL: https://github.com/apache/incubator-kie-drools/pull/6319

   …ts in tests only
   
   **Issue**:
   
   * https://github.com/apache/incubator-kie-drools/issues/6314
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] [incubator-kie-drools-6314] Ability to use pseudo clock with rule uni… [incubator-kie-drools]

Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on code in PR #6319:
URL: https://github.com/apache/incubator-kie-drools/pull/6319#discussion_r2055174615


##########
drools-model/drools-model-codegen/src/main/resources/class-templates/ruleunits/RuleUnitQuarkusTemplate.java:
##########
@@ -44,7 +45,7 @@ public CLASS_NAME() {
     }
 
     @jakarta.inject.Inject
-    public CLASS_NA(jakarta.enterprise.inject.Instance<RuleUnits> ruleUnits) {
+    public CLASS_NAME(jakarta.enterprise.inject.Instance<RuleUnits> ruleUnits) {

Review Comment:
   I happened to find this typo. This was luckily working because RuleUnitWriter processes all constructors, not checking the `CLASS_NA`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] [incubator-kie-drools-6314] Ability to use pseudo clock with rule uni… [incubator-kie-drools]

Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on code in PR #6319:
URL: https://github.com/apache/incubator-kie-drools/pull/6319#discussion_r2055174615


##########
drools-model/drools-model-codegen/src/main/resources/class-templates/ruleunits/RuleUnitQuarkusTemplate.java:
##########
@@ -44,7 +45,7 @@ public CLASS_NAME() {
     }
 
     @jakarta.inject.Inject
-    public CLASS_NA(jakarta.enterprise.inject.Instance<RuleUnits> ruleUnits) {
+    public CLASS_NAME(jakarta.enterprise.inject.Instance<RuleUnits> ruleUnits) {

Review Comment:
   I happened to find this typo. This was luckily working because RuleUnitWriter processes all constructors, not checking the 'CLASS_NA'.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] [incubator-kie-drools-6314] Ability to use pseudo clock with rule uni… [incubator-kie-drools]

Posted by "baldimir (via GitHub)" <gi...@apache.org>.
baldimir commented on code in PR #6319:
URL: https://github.com/apache/incubator-kie-drools/pull/6319#discussion_r2057755106


##########
drools-model/drools-model-codegen/src/main/resources/class-templates/ruleunits/RuleUnitQuarkusTemplate.java:
##########
@@ -44,7 +45,7 @@ public CLASS_NAME() {
     }
 
     @jakarta.inject.Inject
-    public CLASS_NA(jakarta.enterprise.inject.Instance<RuleUnits> ruleUnits) {
+    public CLASS_NAME(jakarta.enterprise.inject.Instance<RuleUnits> ruleUnits) {

Review Comment:
   Ouch :) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] [incubator-kie-drools-6314] Ability to use pseudo clock with rule uni… [incubator-kie-drools]

Posted by "mariofusco (via GitHub)" <gi...@apache.org>.
mariofusco merged PR #6319:
URL: https://github.com/apache/incubator-kie-drools/pull/6319


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] [incubator-kie-drools-6314] Ability to use pseudo clock with rule uni… [incubator-kie-drools]

Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on code in PR #6319:
URL: https://github.com/apache/incubator-kie-drools/pull/6319#discussion_r2055172583


##########
drools-ruleunits/drools-ruleunits-api/src/main/java/org/drools/ruleunits/api/conf/RuleConfig.java:
##########
@@ -36,4 +37,7 @@ public interface RuleConfig {
 
     List<RuleEventListener> getRuleEventListeners();
 
+    ClockType getClockType();
+
+    void setClockType(ClockType clockType);

Review Comment:
   I enhanced `RuleConfig` to override SessionConfiguration at runtime (e.g. for unit test). For now, only ClockType.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] [incubator-kie-drools-6314] Ability to use pseudo clock with rule uni… [incubator-kie-drools]

Posted by "Bonehead5338 (via GitHub)" <gi...@apache.org>.
Bonehead5338 commented on PR #6319:
URL: https://github.com/apache/incubator-kie-drools/pull/6319#issuecomment-2832517935

   awesome


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org