You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "jadami10 (via GitHub)" <gi...@apache.org> on 2025/07/28 00:08:18 UTC
[I] Partition level force commit should not fail for non-consuming segments [pinot]
jadami10 opened a new issue, #16435:
URL: https://github.com/apache/pinot/issues/16435
We are working on orchestrating our rolling restarts such that we try to force commit all segments that have been consuming for > X minutes. What we find is we pre-compute the consuming segments we want to force commit, but as we do this in batches and poll, we eventually hit `Cannot commit segments that are not in CONSUMING state.` introduced in #12088.
It doesn't seem like this needs to be an error. It would be better to either ignore this case or just log a warning. But if a user is requesting to force commit segment S, and it's already committed, then we might as well skip it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] Partition level force commit should not fail for non-consuming segments [pinot]
Posted by "sajjad-moradi (via GitHub)" <gi...@apache.org>.
sajjad-moradi commented on issue #16435:
URL: https://github.com/apache/pinot/issues/16435#issuecomment-3134795649
* You can use the other parameter of this endpoint: `partitions` . That way you don't run into this problem.
* If you insist on providing segment names, I think it's ok to relax the validation and log a warning instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] Partition level force commit should not fail for non-consuming segments [pinot]
Posted by "jadami10 (via GitHub)" <gi...@apache.org>.
jadami10 commented on issue #16435:
URL: https://github.com/apache/pinot/issues/16435#issuecomment-3124814958
@sajjad-moradi, what are your thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] Partition level force commit should not fail for non-consuming segments [pinot]
Posted by "yashmayya (via GitHub)" <gi...@apache.org>.
yashmayya closed issue #16435: Partition level force commit should not fail for non-consuming segments
URL: https://github.com/apache/pinot/issues/16435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org