You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "thswlsqls (via GitHub)" <gi...@apache.org> on 2026/08/06 02:05:30 UTC
[PR] [flink] Fix Flink version detection for key-only deletes on non-release versions [paimon]
thswlsqls opened a new pull request, #9053:
URL: https://github.com/apache/paimon/pull/9053
### Purpose
fix #9052
- `ChangelogModeUtils.isFlink21OrAbove()` split `EnvironmentInformation.getVersion()` on `.` only, leaving `2-SNAPSHOT` as the minor part. The `NumberFormatException` was swallowed, so key-only deletes were disabled on a runtime that has the FLIP-510 API, while the log claimed `requires Flink 2.1+ (current version: 2.2-SNAPSHOT)`.
- This hits Flink built from a release branch or master: the ASF snapshot repository publishes `flink-runtime` as `2.1-SNAPSHOT` and `2.2-SNAPSHOT`. Released `2.1.0` was never affected.
- Split on `.` and `-` instead. One-directional: `2.0-SNAPSHOT`, `2.0-rc1`, `2.0-vvr-11.2-SNAPSHOT` still return `false`, keeping the Flink 2.0 `NoSuchMethodError` guard.
- `E2eTestBase.safelyParseVersion()` already acknowledges suffixed Flink versions.
### Tests
- Added `ChangelogModeUtilsTest#testVersionAtLeast21` / `#testVersionBelow21`.
- `mvn -pl paimon-flink/paimon-flink2-common -Pflink2 clean install` — 18 tests passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] Fix Flink version detection for key-only deletes on non-release versions [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #9053:
URL: https://github.com/apache/paimon/pull/9053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] Fix Flink version detection for key-only deletes on non-release versions [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #9053:
URL: https://github.com/apache/paimon/pull/9053#issuecomment-5199939093
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org