[GitHub] [druid] clintropolis commented on a change in pull request #10947: Add flag in SQL to disable left base filter optimization for joins

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #10947:
URL: https://github.com/apache/druid/pull/10947#discussion_r589956145



##########
File path: processing/src/main/java/org/apache/druid/query/QueryContexts.java
##########
@@ -54,6 +55,10 @@
   public static final String JOIN_FILTER_REWRITE_ENABLE_KEY = "enableJoinFilterRewrite";
   public static final String JOIN_FILTER_REWRITE_VALUE_COLUMN_FILTERS_ENABLE_KEY = "enableJoinFilterRewriteValueColumnFilters";
   public static final String JOIN_FILTER_REWRITE_MAX_SIZE_KEY = "joinFilterRewriteMaxSize";
+  // This flag control whether a sql join query with left scan should be attempted to be run as direct table access
+  // instead of being wrapped inside a query. With direct table access enabled, druid can push down the join operation to
+  // data servers.
+  public static final String SQL_JOIN_LEFT_SCAN_DIRECT = "enableSQLLeftTableScanDirect";

Review comment:
       this should maybe be `enableJoinLeftTableScanDirect` to be more consistent with other join related query context parameters. I also think it should probably be documented, but none of the other join query context parameters are documented (not sure why), so not sure its a blocker for this PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org