You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2018/06/15 11:09:00 UTC

[jira] [Commented] (HBASE-20740) StochasticLoadBalancer should consider Coprocessor request count when computing cost

    [ https://issues.apache.org/jira/browse/HBASE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16513667#comment-16513667 ] 

Ted Yu commented on HBASE-20740:
--------------------------------

bq. only have coprocessor requests

Please describe your use case in more detail: how does coprocessor generate requests (if there is no request from clients).
{code}
+   * @return the number of write requests made to region
+   */
+  public long getCpRequestCount();
{code}
javadoc says write requests but the method name doesn't reflect such (implying read+write). Please go over the patch and make the method name(s) match semantics you want.

Please upload next patch to review board.

> StochasticLoadBalancer should consider Coprocessor request count when computing cost
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-20740
>                 URL: https://issues.apache.org/jira/browse/HBASE-20740
>             Project: HBase
>          Issue Type: Improvement
>          Components: Balancer
>            Reporter: chenxu
>            Assignee: chenxu
>            Priority: Major
>         Attachments: HBASE-20740-master-v1.patch
>
>
> When compute region load cost, ReadRequest, WriteRequest, MemStoreSize and StoreFileSize are considered, But CoprocessorRequests are not include. In our kylin cluster, there only have coprocessor requests,  and the cluster sometimes unbalanced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)