[GitHub] [flink] carp84 commented on a change in pull request #9364: [FLINK-13593][checkpointing] Prevent failing the wrong execution attempt in CheckpointFailureManager

[GitBox <gi...@apache.org>]

carp84 commented on a change in pull request #9364: [FLINK-13593][checkpointing] Prevent failing the wrong execution attempt in CheckpointFailureManager
URL: https://github.com/apache/flink/pull/9364#discussion_r311154653
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
 ##########
 @@ -447,7 +448,7 @@ public boolean triggerCheckpoint(long timestamp, boolean isPeriodic) {
 			long latestGeneratedCheckpointId = getCheckpointIdCounter().get();
 			// here we can not get the failed pending checkpoint's id,
 			// so we pass the negative latest generated checkpoint id as a special flag
-			failureManager.handleCheckpointException(e, -1 * latestGeneratedCheckpointId);
+			failureManager.handleCheckpointException(e, -1 * latestGeneratedCheckpointId, null);
 
 Review comment:
   Actually I already have introduced a new `handleCheckpointException` method with 3 parameters, and adding another one will cause collision.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services