You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/06/27 07:44:21 UTC
[GitHub] [camel-spring-boot-examples] wangyan100 opened a new pull request, #67: sapjcoserver example
wangyan100 opened a new pull request, #67:
URL: https://github.com/apache/camel-spring-boot-examples/pull/67
It is sample to show how to integrate sapjcoserver with Springboot and Apache Camel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot-examples] wangyan100 commented on a diff in pull request #67: sapjcoserver example
Posted by GitBox <gi...@apache.org>.
wangyan100 commented on code in PR #67:
URL: https://github.com/apache/camel-spring-boot-examples/pull/67#discussion_r923618326
##########
sapjcoserver/src/main/resources/application.yaml:
##########
@@ -0,0 +1,32 @@
+camel:
+ springboot:
+ main-run-controller: 'true'
+
+sap:
+ system:
+ name: TESTSAP
+jco:
+ client:
+ ashost: 192.180.32.18
+ client: 600
+ lang: en
+ sysnr: 01
+ user: username
+ passwd: password
+ network: lan
+
+ server:
+ connection_count: 2
+ gwhost: 192.180.14.42
Review Comment:
It is already modified as you suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot-examples] oscerd merged pull request #67: sapjcoserver example
Posted by GitBox <gi...@apache.org>.
oscerd merged PR #67:
URL: https://github.com/apache/camel-spring-boot-examples/pull/67
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot-examples] wangyan100 commented on a diff in pull request #67: sapjcoserver example
Posted by GitBox <gi...@apache.org>.
wangyan100 commented on code in PR #67:
URL: https://github.com/apache/camel-spring-boot-examples/pull/67#discussion_r923617895
##########
sapjcoserver/src/main/resources/application.yaml:
##########
@@ -0,0 +1,32 @@
+camel:
+ springboot:
+ main-run-controller: 'true'
+
+sap:
+ system:
+ name: TESTSAP
+jco:
+ client:
+ ashost: 192.180.32.18
Review Comment:
It is already modified as you suggested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot-examples] zhfeng commented on a diff in pull request #67: sapjcoserver example
Posted by GitBox <gi...@apache.org>.
zhfeng commented on code in PR #67:
URL: https://github.com/apache/camel-spring-boot-examples/pull/67#discussion_r922848800
##########
sapjcoserver/src/test/java/sample/camel/SampleJCOServerApplicationTests.java:
##########
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package sample.camel;
+
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+import java.util.concurrent.TimeUnit;
+
+import org.apache.camel.CamelContext;
+import org.apache.camel.EndpointInject;
+import org.apache.camel.ProducerTemplate;
+import org.apache.camel.builder.NotifyBuilder;
+import org.apache.camel.component.mock.MockEndpoint;
+import org.apache.camel.test.spring.junit5.CamelSpringBootTest;
+import org.junit.jupiter.api.Test;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.test.context.SpringBootTest;
+import org.springframework.test.annotation.DirtiesContext;
+import org.springframework.test.annotation.DirtiesContext.MethodMode;
+
+@CamelSpringBootTest
+@SpringBootTest
+public class SampleJCOServerApplicationTests {
+
+ @Autowired
+ ProducerTemplate producerTemplate;
+
+
+ @Autowired
+ CamelContext camelContext;
+
+ @Test
+ @DirtiesContext(methodMode = MethodMode.AFTER_METHOD)
+ public void testSendMsg() throws Exception {
+ MockEndpoint mockfile = camelContext.getEndpoint("mock:activemq", MockEndpoint.class);
Review Comment:
I think it should be `file:sapoutput` ?
```suggestion
MockEndpoint mockfile = camelContext.getEndpoint("file:sapoutput", MockEndpoint.class);
```
##########
sapjcoserver/src/main/resources/application.yaml:
##########
@@ -0,0 +1,32 @@
+camel:
+ springboot:
+ main-run-controller: 'true'
+
+sap:
+ system:
+ name: TESTSAP
+jco:
+ client:
+ ashost: 192.180.32.18
Review Comment:
It could be useful to get this propery from the system env variables just like `{JCO_ASHOST}`
##########
sapjcoserver/src/main/resources/application.yaml:
##########
@@ -0,0 +1,32 @@
+camel:
+ springboot:
+ main-run-controller: 'true'
+
+sap:
+ system:
+ name: TESTSAP
+jco:
+ client:
+ ashost: 192.180.32.18
+ client: 600
+ lang: en
+ sysnr: 01
+ user: username
+ passwd: password
+ network: lan
+
+ server:
+ connection_count: 2
+ gwhost: 192.180.14.42
Review Comment:
same like above `{JCO_GWHOST}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot-examples] wangyan100 commented on pull request #67: sapjcoserver example
Posted by GitBox <gi...@apache.org>.
wangyan100 commented on PR #67:
URL: https://github.com/apache/camel-spring-boot-examples/pull/67#issuecomment-1193242460
update according reivewer's suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot-examples] wangyan100 commented on pull request #67: sapjcoserver example
Posted by GitBox <gi...@apache.org>.
wangyan100 commented on PR #67:
URL: https://github.com/apache/camel-spring-boot-examples/pull/67#issuecomment-1186535268
Removed jco libs and update readme document for preparing jco already
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot-examples] wangyan100 commented on pull request #67: sapjcoserver example
Posted by GitBox <gi...@apache.org>.
wangyan100 commented on PR #67:
URL: https://github.com/apache/camel-spring-boot-examples/pull/67#issuecomment-1169093273
This example shows how to receive the ABAP function's result and store it at file system.
Data flow
SAP ABAP RFC call -> SpringBoot+ApacheCamel -> FileSystem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org