You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@subversion.apache.org by Stefan Sperling <st...@elego.de> on 2013/02/09 21:19:35 UTC

Re: fsfs.conf knob to have merge() fail rather than automagically rebase Re: Discrepancies in svn mirror created with svnsync

On Sat, Feb 09, 2013 at 03:28:02PM +0200, Daniel Shahaf wrote:
> Under the commit finalization lock, if the txn-being-committed's base
> revision is older than the current HEAD, by default the code will commit
> it anyway provided that no conflicting changes were made in the interim.
> I wonder if it would be a good idea to have a fsfs.conf knob that tells
> the code to just give up if {txn's base revision} != {current HEAD}.
> Then that knob would be recommended to be set on every repository which
> is an svnsync slave repository.

If it's recommended, why not have 'svnsync init' tweak the config file
accordingly? And we could take this one step further by hiding the flag
somewhere in the repository instead of putting it in the config file.

Re: fsfs.conf knob to have merge() fail rather than automagically rebase Re: Discrepancies in svn mirror created with svnsync

Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Stefan Sperling wrote on Sat, Feb 09, 2013 at 21:19:35 +0100:
> On Sat, Feb 09, 2013 at 03:28:02PM +0200, Daniel Shahaf wrote:
> > Under the commit finalization lock, if the txn-being-committed's base
> > revision is older than the current HEAD, by default the code will commit
> > it anyway provided that no conflicting changes were made in the interim.
> > I wonder if it would be a good idea to have a fsfs.conf knob that tells
> > the code to just give up if {txn's base revision} != {current HEAD}.
> > Then that knob would be recommended to be set on every repository which
> > is an svnsync slave repository.
> 
> If it's recommended, why not have 'svnsync init' tweak the config file
> accordingly?

Because it works over libsvn_ra.

> And we could take this one step further by hiding the flag
> somewhere in the repository instead of putting it in the config file.

Sure, we could move the config file to a $REPOS_DIR/db/../foo.conf, or
an r0 revprop that FS backends be required to respect, etc.  Not sure
what would be the best place.