[GitHub] [airflow] o-nikolas commented on a diff in pull request #31757: feat(jobs/triggerer_job_runner): add triggerer canceled log

["o-nikolas (via GitHub)" <gi...@apache.org>]

o-nikolas commented on code in PR #31757:
URL: https://github.com/apache/airflow/pull/31757#discussion_r1222177108


##########
airflow/jobs/triggerer_job_runner.py:
##########
@@ -608,6 +608,8 @@ async def run_trigger(self, trigger_id, trigger):
                 self.log.info("Trigger %s fired: %s", self.triggers[trigger_id]["name"], event)
                 self.triggers[trigger_id]["events"] += 1
                 self.events.append((trigger_id, event))
+        except asyncio.CancelledError:
+            self.log.info("Trigger cancelled")

Review Comment:
   The issue that this was trying to address was communicating to the user that there was a timeout. If I was a user and saw "Trigger cancelled" I would be confused because I had not cancelled anything and I would have to trace through the code base (if I'm able as a code-y user) to find out that it was actually a timeout.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org