You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2017/05/01 17:29:46 UTC

[GitHub] spark pull request #17764: [SPARK-20463] Add support for IS [NOT] DISTINCT F...

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17764#discussion_r114160222
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ---
    @@ -962,6 +962,11 @@ class AstBuilder extends SqlBaseBaseVisitor[AnyRef] with Logging {
             IsNotNull(e)
           case SqlBaseParser.NULL =>
             IsNull(e)
    +      case SqlBaseParser.DISTINCT =>
    +        ctx.NOT match {
    +          case null => Not(EqualTo(e, expression(ctx.right)))
    --- End diff --
    
    ```Scala
    case null => Not(EqualTo(e, expression(ctx.right)))
    ```
    ->
    ```Scala
    case null => Not(EqualNullSafe(e, expression(ctx.right)))
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org