You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "tomncooper (via GitHub)" <gi...@apache.org> on 2025/08/27 16:37:04 UTC

[PR] [FLINK-38289] Update to Flink 2.1 [flink-connector-kafka]

tomncooper opened a new pull request, #187:
URL: https://github.com/apache/flink-connector-kafka/pull/187

   This PR updates the Flink version to 2.1.0. 
   
   The main issue with this update is that Flink has [removed](https://github.com/apache/flink/pull/26784) (without deprecating first) the `stripRowPrefix` method from the  `DataTypeUtilsTest` class. So this PR adds that logic into a util class within the connector. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38289] Update to Flink 2.1 [flink-connector-kafka]

Posted by "jessechencx (via GitHub)" <gi...@apache.org>.
jessechencx commented on PR #187:
URL: https://github.com/apache/flink-connector-kafka/pull/187#issuecomment-3388105145

   when publish? i not found it in mvnrepository .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38289] Update to Flink 2.1 [flink-connector-kafka]

Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on PR #187:
URL: https://github.com/apache/flink-connector-kafka/pull/187#issuecomment-3237478936

   @tomncooper looks like you have conflicts


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38289] Update to Flink 2.1 [flink-connector-kafka]

Posted by "gaborgsomogyi (via GitHub)" <gi...@apache.org>.
gaborgsomogyi commented on PR #187:
URL: https://github.com/apache/flink-connector-kafka/pull/187#issuecomment-3354890607

   First I need to release Flink 2.1.1 and then we can take a look at this connector...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38289] Update to Flink 2.1 [flink-connector-kafka]

Posted by "tachun-shen-appier (via GitHub)" <gi...@apache.org>.
tachun-shen-appier commented on PR #187:
URL: https://github.com/apache/flink-connector-kafka/pull/187#issuecomment-3471449299

   It seems that Flink 2.1.1 is released. Is there any blocking issue?
   https://github.com/apache/flink/releases/tag/release-2.1.1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38289] Update to Flink 2.1 [flink-connector-kafka]

Posted by "raphaelauv (via GitHub)" <gi...@apache.org>.
raphaelauv commented on PR #187:
URL: https://github.com/apache/flink-connector-kafka/pull/187#issuecomment-3353578576

   hi @gaborgsomogyi , is there any release planned ?
   
   flink 2.1 and kafka 4.0 are great new features 
   
   Thanks 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38289] Update to Flink 2.1 [flink-connector-kafka]

Posted by "mdemierre (via GitHub)" <gi...@apache.org>.
mdemierre commented on PR #187:
URL: https://github.com/apache/flink-connector-kafka/pull/187#issuecomment-3758582376

   Hello @gaborgsomogyi, sorry to bump this thread but I couldn't find any thread in the mailing lists related to this.
   
   Are there releases of the connector planned for Flink 2.1 and 2.2?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38289] Update to Flink 2.1 [flink-connector-kafka]

Posted by "gaborgsomogyi (via GitHub)" <gi...@apache.org>.
gaborgsomogyi merged PR #187:
URL: https://github.com/apache/flink-connector-kafka/pull/187


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38289] Update to Flink 2.1 [flink-connector-kafka]

Posted by "tomncooper (via GitHub)" <gi...@apache.org>.
tomncooper commented on PR #187:
URL: https://github.com/apache/flink-connector-kafka/pull/187#issuecomment-3232961369

   > Please spotless the code
   
   Believe me I am trying, but running `mvn spotless:check` locally (with maven 3.8.6 and Java 17) reveals no issues. It appears all the checks are skipped?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38289] Update to Flink 2.1 [flink-connector-kafka]

Posted by "gaborgsomogyi (via GitHub)" <gi...@apache.org>.
gaborgsomogyi commented on PR #187:
URL: https://github.com/apache/flink-connector-kafka/pull/187#issuecomment-3234281741

   Leaving it open for couple of days in order to wait for comments from others.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38289] Update to Flink 2.1 [flink-connector-kafka]

Posted by "gaborgsomogyi (via GitHub)" <gi...@apache.org>.
gaborgsomogyi commented on PR #187:
URL: https://github.com/apache/flink-connector-kafka/pull/187#issuecomment-3758632540

   No planned release yet. If you ask me it would be better if we would release it with 2.2 support. I've tried to bump it here but stuck because failing tests: https://github.com/apache/flink-connector-kafka/pull/204


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38289] Update to Flink 2.1 [flink-connector-kafka]

Posted by "zackary-naas (via GitHub)" <gi...@apache.org>.
zackary-naas commented on PR #187:
URL: https://github.com/apache/flink-connector-kafka/pull/187#issuecomment-3428444359

   Any update here? Would like to start using Flink 2.1 officially, but this is the last remaining piece needed for our org. Let me know if there is anything I can do to contribute or assist in any way. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38289] Update to Flink 2.1 [flink-connector-kafka]

Posted by "tomncooper (via GitHub)" <gi...@apache.org>.
tomncooper commented on PR #187:
URL: https://github.com/apache/flink-connector-kafka/pull/187#issuecomment-3233020448

   So the reason it skips it locally is that it is defaulted to that in the [connector parent pom](https://github.com/apache/flink-connector-shared-utils/blob/d719c95235db17f5932d1bb5d917f7d6e195c371/pom.xml#L842). I am not sure what in the [ci config](https://github.com/apache/flink-connector-shared-utils/blob/f80c245c1585a26cc51fb23fb100c86341bb5686/.github/workflows/ci.yml#L173) overrides that, but I had to manually add the spotless plugin to the build config, and set skip to false, in each child module to get it to run.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38289] Update to Flink 2.1 [flink-connector-kafka]

Posted by "gaborgsomogyi (via GitHub)" <gi...@apache.org>.
gaborgsomogyi commented on PR #187:
URL: https://github.com/apache/flink-connector-kafka/pull/187#issuecomment-3232435374

   Tests are pending.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org