You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2023/01/04 13:10:59 UTC

[GitHub] [beam] olehborysevych opened a new pull request, #24873: Playground runners scala update

olehborysevych opened a new pull request, #24873:
URL: https://github.com/apache/beam/pull/24873

   Whitelisting maven repo for sbt to work
   Externalizing grpc timeout
   Adding example deployment to readme
   fixes #24872
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #24873: Playground runners scala update

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24873:
URL: https://github.com/apache/beam/pull/24873#issuecomment-1371043045

   Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on pull request #24873: Playground runners scala update

Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #24873:
URL: https://github.com/apache/beam/pull/24873#issuecomment-1371069544

   LGTM, thanks! Just one nit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on a diff in pull request #24873: Playground runners scala update

Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #24873:
URL: https://github.com/apache/beam/pull/24873#discussion_r1061588007


##########
playground/README.md:
##########
@@ -120,3 +120,50 @@ cd beam
 
 See [terraform](./terraform/README.md) for details on how to build and deploy
 the application and its dependent infrastructure.
+
+# Manual Example deployment
+
+The following requirements are needed for deploying examples manually.
+
+1. GCP project with deployed Playground backend
+2. Python (3.9.x)
+3. Login into GCP (gcloud deafult login or using service account key)

Review Comment:
   ```suggestion
   3. Login into GCP (gcloud default login or using service account key)
   ```
   
   Nit



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] olehborysevych commented on pull request #24873: Playground runners scala update

Posted by GitBox <gi...@apache.org>.
olehborysevych commented on PR #24873:
URL: https://github.com/apache/beam/pull/24873#issuecomment-1371041254

   R: @damccorm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on a diff in pull request #24873: Playground runners scala update

Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #24873:
URL: https://github.com/apache/beam/pull/24873#discussion_r1061646311


##########
playground/README.md:
##########
@@ -120,3 +120,50 @@ cd beam
 
 See [terraform](./terraform/README.md) for details on how to build and deploy
 the application and its dependent infrastructure.
+
+# Manual Example deployment
+
+The following requirements are needed for deploying examples manually:
+
+1. GCP project with deployed Playground backend
+2. Python (3.9.x)
+3. Login into GCP (gcloud deafault login or using service account key)

Review Comment:
   ```suggestion
   3. Login into GCP (gcloud default login or using service account key)
   ```
   
   Nit - looks like an extra `a` still slipped in



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm merged pull request #24873: Playground runners scala update

Posted by GitBox <gi...@apache.org>.
damccorm merged PR #24873:
URL: https://github.com/apache/beam/pull/24873


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org