[GitHub] [hadoop] mukund-thakur commented on a change in pull request #2148: HADOOP-17131 Moving listing to use operation callback

[GitBox <gi...@apache.org>]

mukund-thakur commented on a change in pull request #2148:
URL: https://github.com/apache/hadoop/pull/2148#discussion_r462841126



##########
File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
##########
@@ -4847,5 +4800,20 @@ public String getBucketLocation() throws IOException {
     public Path makeQualified(final Path path) {
       return S3AFileSystem.this.makeQualified(path);
     }
+

Review comment:
       Felt like below three methods are generic for context so I added here such that if required in future it can be used by other operations as well. I think the reason you are saying to add in ListingOperationCallbacks is because these are currently only used in Listing Operations.
   I can put in Listing as well.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org