You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/08/23 00:45:22 UTC

[jira] [Commented] (HADOOP-13533) User cannot set empty HADOOP_SSH_OPTS environment variable option

    [ https://issues.apache.org/jira/browse/HADOOP-13533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431874#comment-15431874 ] 

ASF GitHub Bot commented on HADOOP-13533:
-----------------------------------------

GitHub user chu11 opened a pull request:

    https://github.com/apache/hadoop/pull/121

    HADOOP-13533: Do not require user to set HADOOP_SSH_OPTS to a non-null string, allow

    setting of an empty string.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chu11/hadoop HADOOP-13533

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/hadoop/pull/121.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #121
    
----
commit 952f515ca5251f064c62187a4268d1359bb271f7
Author: Albert Chu <ch...@llnl.gov>
Date:   2016-08-23T00:41:41Z

    Do not require user to set HADOOP_SSH_OPTS to a non-null string, allow
    setting of an empty string.

----


> User cannot set empty HADOOP_SSH_OPTS environment variable option
> -----------------------------------------------------------------
>
>                 Key: HADOOP-13533
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13533
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Albert Chu
>            Priority: Minor
>
> In hadoop-functions.sh in the hadoop_basic_init function there is this initialization of HADOOP_SSH_OPTS:
> {noformat}
> HADOOP_SSH_OPTS=${HADOOP_SSH_OPTS:-"-o BatchMode=yes -o StrictHostKeyChecking=no -o ConnectTimeout=10s"}
> {noformat}
> I believe this parameter substitution is a bug.  While most of the environment variables set in the function are generally required for functionality (HADOOP_LOG_DIR, HADOOP_LOGFILE, etc.) I don't believe HADOOP_SSH_OPTS is one of them.  If the user wishes to set HADOOP_SSH_OPTS to an empty string (i.e. HADOOP_SSH_OPTS="") they should be able to.  But instead, this is requiring HADOOP_SSH_OPTS to always be set to something.
> So I think the ":-" in the above should be "-".  Github pull request to be sent shortly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org