Re: Review Request 21734: MESOS-390 Handle file:// in fetcher

[Timothy Chen <tn...@apache.org>]

> On May 28, 2014, 10:47 p.m., Adam B wrote:
> > src/launcher/fetcher.cpp, lines 141-142
> > <https://reviews.apache.org/r/21734/diff/2/?file=587748#file587748line141>
> >
> >     Can you LOG(ERROR) here too?
> >     Is there a reason you need to do this check here rather than rely on the local.find_first_of("/")!=0 below?
> >     Is one of these checks better than the other? I would think that startsWith would be able to exit earlier (after 1st char) than find_first_of (after 1st '/'). Perhaps we should change it too.

The reason I did an explicit check here is because technically File URI in linux doesn't support relative paths, so I want to keep the same semantics.
The code below that is actually prepending MESOS_FRAMEWORKS_HOME if it's a relative path.
I think we shouldn't allow relative paths given a file://.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21734/#review44187
-----------------------------------------------------------


On May 22, 2014, 3:29 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21734/
> -----------------------------------------------------------
> 
> (Updated May 22, 2014, 3:29 a.m.)
> 
> 
> Review request for mesos, Adam B and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Handling file:// in the fetcher, and also handle case when localhost is used.
> 
> 
> Diffs
> -----
> 
>   src/launcher/fetcher.cpp 8c9e20d 
> 
> Diff: https://reviews.apache.org/r/21734/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>