You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "pitrou (via GitHub)" <gi...@apache.org> on 2024/01/16 11:18:12 UTC
[PR] GH-39562: [C++][Parquet] Fix crash [arrow]
pitrou opened a new pull request, #39632:
URL: https://github.com/apache/arrow/pull/39632
TODO complete this description
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
### What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
### Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
### Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39562: [C++][Parquet] Fix crash [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #39632:
URL: https://github.com/apache/arrow/pull/39632#issuecomment-1893544120
@github-actions crossbow submit wheel-macos*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39562: [C++][Parquet] Fix crash [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39632:
URL: https://github.com/apache/arrow/pull/39632#issuecomment-1893545050
```
Only contributors can submit requests to this bot. Please ask someone from the community for help with getting the first commit in.
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7540837592
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39562: [C++][Parquet] Fix crash in test_parquet_dataset_lazy_filtering [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #39632:
URL: https://github.com/apache/arrow/pull/39632#issuecomment-1893852325
@raulcd I marked this for 15.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39562: [C++][Parquet] Fix crash in test_parquet_dataset_lazy_filtering [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #39632:
URL: https://github.com/apache/arrow/pull/39632
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39562: [C++][Parquet] Fix crash in test_parquet_dataset_lazy_filtering [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #39632:
URL: https://github.com/apache/arrow/pull/39632#issuecomment-1894825213
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 4b3de819708d4de29247676bacb78f3e7a749a6f.
There was 1 benchmark result with an error:
- Commit Run on `ursa-i9-9960x` at [2024-01-16 16:10:16Z](https://conbench.ursa.dev/compare/runs/fbd45133e4f34868a982b6560d5b677f...7b81be5d005b44b68a044669c5b76051/)
- [`dataframe-to-table` (R) with dataset=chi_traffic_2020_Q1, language=R](https://conbench.ursa.dev/benchmark-results/065a6b653c5d796a80000ec239daba40)
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/20555272727) has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39562: [C++][Parquet] Fix crash [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #39632:
URL: https://github.com/apache/arrow/pull/39632#discussion_r1453373072
##########
cpp/src/arrow/dataset/file_parquet.cc:
##########
@@ -813,11 +813,17 @@ Status ParquetFileFragment::EnsureCompleteMetadata(parquet::arrow::FileReader* r
Status ParquetFileFragment::SetMetadata(
std::shared_ptr<parquet::FileMetaData> metadata,
- std::shared_ptr<parquet::arrow::SchemaManifest> manifest) {
+ std::shared_ptr<parquet::arrow::SchemaManifest> manifest,
+ std::shared_ptr<parquet::FileMetaData> original_metadata) {
DCHECK(row_groups_.has_value());
metadata_ = std::move(metadata);
manifest_ = std::move(manifest);
+ original_metadata_ = original_metadata ? std::move(original_metadata) : metadata_;
Review Comment:
Do you mean `FileMetaData::Subset`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39562: [C++][Parquet] Fix crash [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39632:
URL: https://github.com/apache/arrow/pull/39632#issuecomment-1893543494
:warning: GitHub issue #39562 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39562: [C++][Parquet] Fix crash [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39632:
URL: https://github.com/apache/arrow/pull/39632#issuecomment-1893564160
Revision: 8978cef3c1754fa1e9fe04bedc4ad4d659ce2750
Submitted crossbow builds: [ursacomputing/crossbow @ actions-2f9bd68461](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2f9bd68461)
|Task|Status|
|----|------|
|wheel-macos-big-sur-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7540968045/job/20526684115)|
|wheel-macos-big-sur-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7540967837/job/20526683576)|
|wheel-macos-big-sur-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7540967988/job/20526684045)|
|wheel-macos-big-sur-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7540968181/job/20526684818)|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7540968046/job/20526684293)|
|wheel-macos-catalina-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7540968072/job/20526684203)|
|wheel-macos-catalina-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7540967854/job/20526683579)|
|wheel-macos-catalina-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7540967945/job/20526683925)|
|wheel-macos-catalina-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7540968241/job/20526684825)|
|wheel-macos-catalina-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7540968165/job/20526684817)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39562: [C++][Parquet] Fix crash [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #39632:
URL: https://github.com/apache/arrow/pull/39632#issuecomment-1893560110
@github-actions crossbow submit wheel-macos*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39562: [C++][Parquet] Fix crash in test_parquet_dataset_lazy_filtering [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39632:
URL: https://github.com/apache/arrow/pull/39632#issuecomment-1893741528
Revision: 8978cef3c1754fa1e9fe04bedc4ad4d659ce2750
Submitted crossbow builds: [ursacomputing/crossbow @ actions-8a0ca7497c](https://github.com/ursacomputing/crossbow/branches/all?query=actions-8a0ca7497c)
|Task|Status|
|----|------|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions/runs/7542263989/job/20530680526)|
|test-conda-python-3.10-cython2|[](https://github.com/ursacomputing/crossbow/actions/runs/7542262908/job/20530675924)|
|test-conda-python-3.10-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/7542262839/job/20530675814)|
|test-conda-python-3.10-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/7542263296/job/20530677230)|
|test-conda-python-3.10-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/7542263956/job/20530680238)|
|test-conda-python-3.10-pandas-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/7542263689/job/20530679293)|
|test-conda-python-3.10-spark-v3.5.0|[](https://github.com/ursacomputing/crossbow/actions/runs/7542263165/job/20530676904)|
|test-conda-python-3.10-substrait|[](https://github.com/ursacomputing/crossbow/actions/runs/7542263580/job/20530678568)|
|test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/7542264296/job/20530681893)|
|test-conda-python-3.11-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/7542263994/job/20530680533)|
|test-conda-python-3.11-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/7542264286/job/20530681684)|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/7542264266/job/20530681906)|
|test-conda-python-3.11-pandas-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/7542263548/job/20530678457)|
|test-conda-python-3.11-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/7542263571/job/20530678452)|
|test-conda-python-3.12|[](https://github.com/ursacomputing/crossbow/actions/runs/7542264257/job/20530681532)|
|test-conda-python-3.8|[](https://github.com/ursacomputing/crossbow/actions/runs/7542263024/job/20530676432)|
|test-conda-python-3.8-pandas-1.0|[](https://github.com/ursacomputing/crossbow/actions/runs/7542263311/job/20530677374)|
|test-conda-python-3.8-spark-v3.5.0|[](https://github.com/ursacomputing/crossbow/actions/runs/7542262955/job/20530676259)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions/runs/7542264282/job/20530681669)|
|test-conda-python-3.9-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/7542264394/job/20530682242)|
|test-cuda-python|[](https://github.com/ursacomputing/crossbow/actions/runs/7542263615/job/20530678793)|
|test-debian-11-python-3|[](https://github.com/ursacomputing/crossbow/runs/20530681072)|
|test-fedora-38-python-3|[](https://github.com/ursacomputing/crossbow/runs/20530678838)|
|test-ubuntu-20.04-python-3|[](https://github.com/ursacomputing/crossbow/runs/20530678081)|
|test-ubuntu-22.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/7542263856/job/20530679939)|
|wheel-macos-big-sur-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542263437/job/20530677813)|
|wheel-macos-big-sur-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542262926/job/20530676176)|
|wheel-macos-big-sur-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542264426/job/20530682640)|
|wheel-macos-big-sur-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542264489/job/20530721814)|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542262686/job/20530674987)|
|wheel-macos-catalina-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542263688/job/20530679115)|
|wheel-macos-catalina-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542262737/job/20530675150)|
|wheel-macos-catalina-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542264476/job/20530682633)|
|wheel-macos-catalina-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542264406/job/20530682330)|
|wheel-macos-catalina-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542262752/job/20530675254)|
|wheel-manylinux-2-28-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542262966/job/20530676355)|
|wheel-manylinux-2-28-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542263910/job/20530680175)|
|wheel-manylinux-2-28-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542263766/job/20530679559)|
|wheel-manylinux-2-28-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542263685/job/20530679154)|
|wheel-manylinux-2-28-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542264176/job/20530681193)|
|wheel-manylinux-2-28-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542262710/job/20530675639)|
|wheel-manylinux-2-28-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542263367/job/20530677614)|
|wheel-manylinux-2-28-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542263818/job/20530679725)|
|wheel-manylinux-2-28-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542262788/job/20530675634)|
|wheel-manylinux-2-28-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542263513/job/20530678161)|
|wheel-manylinux-2014-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542263853/job/20530679815)|
|wheel-manylinux-2014-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542263384/job/20530677518)|
|wheel-manylinux-2014-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542263446/job/20530677826)|
|wheel-manylinux-2014-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542262664/job/20530674994)|
|wheel-manylinux-2014-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542263193/job/20530677004)|
|wheel-manylinux-2014-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542263232/job/20530677117)|
|wheel-manylinux-2014-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542264389/job/20530681945)|
|wheel-manylinux-2014-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542262828/job/20530675917)|
|wheel-manylinux-2014-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542264482/job/20530721764)|
|wheel-manylinux-2014-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542263532/job/20530678224)|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542264121/job/20530681046)|
|wheel-windows-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542263121/job/20530676850)|
|wheel-windows-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542264115/job/20530681071)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542263061/job/20530676673)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7542263995/job/20530680716)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39562: [C++][Parquet] Fix crash [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #39632:
URL: https://github.com/apache/arrow/pull/39632#issuecomment-1893658337
@github-actions crossbow submit wheel-macos*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39562: [C++][Parquet] Fix crash [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #39632:
URL: https://github.com/apache/arrow/pull/39632#issuecomment-1893558800
This https://github.com/apache/arrow/commit/b59082a72094f112f95914a1d8ad469db87a34c9 might have broken the crossbow submissions for committers that don't have their membership set to Public (https://github.com/orgs/apache/people?query=pitrou)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39562: [C++][Parquet] Fix crash [arrow]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on code in PR #39632:
URL: https://github.com/apache/arrow/pull/39632#discussion_r1453379429
##########
cpp/src/arrow/dataset/file_parquet.cc:
##########
@@ -813,11 +813,17 @@ Status ParquetFileFragment::EnsureCompleteMetadata(parquet::arrow::FileReader* r
Status ParquetFileFragment::SetMetadata(
std::shared_ptr<parquet::FileMetaData> metadata,
- std::shared_ptr<parquet::arrow::SchemaManifest> manifest) {
+ std::shared_ptr<parquet::arrow::SchemaManifest> manifest,
+ std::shared_ptr<parquet::FileMetaData> original_metadata) {
DCHECK(row_groups_.has_value());
metadata_ = std::move(metadata);
manifest_ = std::move(manifest);
+ original_metadata_ = original_metadata ? std::move(original_metadata) : metadata_;
Review Comment:
Yeah, I misunderstand this previously, `metadata_` is from Subset, but `manifest` is shared and having lifetime problem here.
##########
cpp/src/arrow/dataset/file_parquet.cc:
##########
@@ -813,11 +813,17 @@ Status ParquetFileFragment::EnsureCompleteMetadata(parquet::arrow::FileReader* r
Status ParquetFileFragment::SetMetadata(
std::shared_ptr<parquet::FileMetaData> metadata,
- std::shared_ptr<parquet::arrow::SchemaManifest> manifest) {
+ std::shared_ptr<parquet::arrow::SchemaManifest> manifest,
+ std::shared_ptr<parquet::FileMetaData> original_metadata) {
DCHECK(row_groups_.has_value());
metadata_ = std::move(metadata);
manifest_ = std::move(manifest);
+ original_metadata_ = original_metadata ? std::move(original_metadata) : metadata_;
Review Comment:
Yeah, I misunderstand this previously, `metadata_` is from Subset, but `manifest` is shared and having lifetime problem here, this looks ok to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39562: [C++][Parquet] Fix crash in test_parquet_dataset_lazy_filtering [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #39632:
URL: https://github.com/apache/arrow/pull/39632#issuecomment-1893735777
@github-actions crossbow submit -g wheel -g python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39562: [C++][Parquet] Fix crash [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39632:
URL: https://github.com/apache/arrow/pull/39632#issuecomment-1893661824
Revision: 8978cef3c1754fa1e9fe04bedc4ad4d659ce2750
Submitted crossbow builds: [ursacomputing/crossbow @ actions-b28f7d7852](https://github.com/ursacomputing/crossbow/branches/all?query=actions-b28f7d7852)
|Task|Status|
|----|------|
|wheel-macos-big-sur-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7541688955/job/20528933726)|
|wheel-macos-big-sur-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7541688711/job/20528932567)|
|wheel-macos-big-sur-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7541688783/job/20528932587)|
|wheel-macos-big-sur-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7541688825/job/20528933075)|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7541688798/job/20528932972)|
|wheel-macos-catalina-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7541688918/job/20528933442)|
|wheel-macos-catalina-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7541688931/job/20528933439)|
|wheel-macos-catalina-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7541688777/job/20528932619)|
|wheel-macos-catalina-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7541688943/job/20528933729)|
|wheel-macos-catalina-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7541688927/job/20528933443)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39562: [C++][Parquet] Fix crash in test_parquet_dataset_lazy_filtering [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on PR #39632:
URL: https://github.com/apache/arrow/pull/39632#issuecomment-1893739051
Nice! Yes, running once more to be sure is best (it happened before there were no failures in a single run of all wheel builds)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39562: [C++][Parquet] Fix crash in test_parquet_dataset_lazy_filtering [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #39632:
URL: https://github.com/apache/arrow/pull/39632#issuecomment-1893735553
@jorisvandenbossche This seems to have addressed the issue. Should we run the tests another time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39562: [C++][Parquet] Fix crash [arrow]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on code in PR #39632:
URL: https://github.com/apache/arrow/pull/39632#discussion_r1453291973
##########
cpp/src/arrow/dataset/file_parquet.cc:
##########
@@ -813,11 +813,17 @@ Status ParquetFileFragment::EnsureCompleteMetadata(parquet::arrow::FileReader* r
Status ParquetFileFragment::SetMetadata(
std::shared_ptr<parquet::FileMetaData> metadata,
- std::shared_ptr<parquet::arrow::SchemaManifest> manifest) {
+ std::shared_ptr<parquet::arrow::SchemaManifest> manifest,
+ std::shared_ptr<parquet::FileMetaData> original_metadata) {
DCHECK(row_groups_.has_value());
metadata_ = std::move(metadata);
manifest_ = std::move(manifest);
+ original_metadata_ = original_metadata ? std::move(original_metadata) : metadata_;
Review Comment:
This is ok for be but should we check `Subset` for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org