[GitHub] [lucene] sherman commented on pull request #12290: Make memory fence in `ByteBufferGuard` explicit

["sherman (via GitHub)" <gi...@apache.org>]

sherman commented on PR #12290:
URL: https://github.com/apache/lucene/pull/12290#issuecomment-1549883140

   I think it's a good idea to replace this tricky way to flush any CPU caches, such as using lazy set, with an explicit full fence. The purpose of a full fence is to provide a reliable memory barrier that works consistently across different architectures.
   
   But if you're quite certain that the days of this class are numbered, then it's fine.
   
   (By the way, we are still planning to test it in our implementation of the directory interface).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org