You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "jayakasadev (via GitHub)" <gi...@apache.org> on 2026/05/18 19:54:00 UTC
Re: [I] Remove overreliance on Identifier from server [iggy]
jayakasadev commented on issue #2590:
URL: https://github.com/apache/iggy/issues/2590#issuecomment-4481483953
I'd like to pick this up. PR #2555 (LeftRight metadata) merged in January so the blocker is cleared.
My read on translation layer placement: the per-shard request handler, after deserialization but before the command reaches `apply()` — that gives the parser read access to the metadata index without crossing state machine isolation boundaries. `ConsumerGroup` commands would arrive with numeric `stream_id`/`topic_id` already resolved.
A few questions before starting:
- Is the expected contract "error on not-found at parse time" (cleaner, requires index read-access at the handler layer) or "pass numeric -1/sentinel and let the state machine reject"?
- Should `Identifier` be removed from the state-machine-facing command types only, or from public SDK/protocol types too?
- Anything already in-flight or in a branch I should be aware of?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org