You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Ashish Singh <as...@cloudera.com> on 2014/12/14 20:21:12 UTC

Review Request 29030: KAFKA-742: Existing directories under the Kafka data directory without any data cause process to not start

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29030/
-----------------------------------------------------------

Review request for kafka.


Bugs: KAFKA-742
    https://issues.apache.org/jira/browse/KAFKA-742


Repository: kafka


Description
-------

KAFKA-742: Existing directories under the Kafka data directory without any data cause process to not start


Diffs
-----

  core/src/main/scala/kafka/log/Log.scala 4fae2f0d339b256832baa62ca4995d10546716b4 
  core/src/test/scala/unit/kafka/log/LogTest.scala d670ba76acd54e3e88855c56c152c7cc36dddfdc 

Diff: https://reviews.apache.org/r/29030/diff/


Testing
-------


Thanks,

Ashish Singh


Re: Review Request 29030: KAFKA-742: Existing directories under the Kafka data directory without any data cause process to not start

Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29030/#review65287
-----------------------------------------------------------

Ship it!


Ship It!

- Neha Narkhede


On Dec. 16, 2014, 6:27 p.m., Ashish Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29030/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2014, 6:27 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-742
>     https://issues.apache.org/jira/browse/KAFKA-742
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-742: Existing directories under the Kafka data directory without any data cause process to not start
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/log/Log.scala 4fae2f0d339b256832baa62ca4995d10546716b4 
>   core/src/main/scala/kafka/log/LogManager.scala 4d2924d04bc4bd62413edb0ee2d4aaf3c0052867 
>   core/src/test/scala/unit/kafka/log/LogTest.scala d670ba76acd54e3e88855c56c152c7cc36dddfdc 
> 
> Diff: https://reviews.apache.org/r/29030/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashish Singh
> 
>


Re: Review Request 29030: KAFKA-742: Existing directories under the Kafka data directory without any data cause process to not start

Posted by Ashish Singh <as...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29030/
-----------------------------------------------------------

(Updated Dec. 16, 2014, 6:27 p.m.)


Review request for kafka.


Changes
-------

Have exception print whole path for dir causing issue, rather than just name of dir.


Bugs: KAFKA-742
    https://issues.apache.org/jira/browse/KAFKA-742


Repository: kafka


Description
-------

KAFKA-742: Existing directories under the Kafka data directory without any data cause process to not start


Diffs (updated)
-----

  core/src/main/scala/kafka/log/Log.scala 4fae2f0d339b256832baa62ca4995d10546716b4 
  core/src/main/scala/kafka/log/LogManager.scala 4d2924d04bc4bd62413edb0ee2d4aaf3c0052867 
  core/src/test/scala/unit/kafka/log/LogTest.scala d670ba76acd54e3e88855c56c152c7cc36dddfdc 

Diff: https://reviews.apache.org/r/29030/diff/


Testing
-------


Thanks,

Ashish Singh