[GitHub] [helix] narendly edited a comment on pull request #1531: Fix bug in resetting ByteArrayZkClient

[GitBox <gi...@apache.org>]

narendly edited a comment on pull request #1531:
URL: https://github.com/apache/helix/pull/1531#issuecomment-728377678


   
   I added: 
   
   > More specifically, the code was closing byteArrayDataAccessor but not byteArrayZkClient. This meant that the same byteArrayZkClient would be used even though everything was reset and routing data was updated. Hence, the data accessor was not really being created from scratch. This change makes sure that the underlying byteArrayZkClient gets closed and nullified upon routing data change.
   
   Let me know if this is clearer!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org