[GitHub] [helix] jiajunwang commented on issue #680: Question on CrushEd rebalance algorithm and MasterSalve state model for Pinot

[GitBox <gi...@apache.org>]

jiajunwang commented on issue #680: Question on CrushEd rebalance algorithm and MasterSalve state model for Pinot
URL: https://github.com/apache/helix/issues/680#issuecomment-573918795
 
 
   I had some discussion with Jack offline. My take away is that the AutoRebalanceStrategy with OnlineOffline state model might work for Pinot for now. But it has some limitations and may impact future changes. For example, this strategy is not rack-aware. As for the OnlineOffline state model, once there are more than 2 replicas, we will have multiple online replicas. I assume it might cause issues.
   
   In addition, I'm not sure what does "simplified" mean for Pinot? The CrushEd algorithm is internally more complicated, but it is more stable and performs better than the legacy strategy. So eventually, the CrushEd strategy should help to simplify the application code more. I remember it is part of the reason we decided to go with the CrushEd strategy.
   
   @dasahcc @lei-xia Could you please also take a look in case I missed anything.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org