[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7203: Fix race in historical when loading segments in parallel

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #7203: Fix race in historical when loading segments in parallel
URL: https://github.com/apache/incubator-druid/pull/7203#discussion_r263158128
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/server/SegmentManager.java
 ##########
 @@ -192,12 +194,14 @@ public boolean loadSegment(final DataSegment segment) throws SegmentLoadingExcep
   private Segment getAdapter(final DataSegment segment) throws SegmentLoadingException
   {
     final Segment adapter;
-    try {
-      adapter = segmentLoader.getSegment(segment);
-    }
-    catch (SegmentLoadingException e) {
-      segmentLoader.cleanup(segment);
-      throw e;
+    synchronized (segmentLoader) {
 
 Review comment:
   Oh right. Thank you for catching. I'll fix this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org