[jira] [Comment Edited] (DIRKRB-229) Enhance kadmin to support list principals

["Lin Chen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DIRKRB-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14508918#comment-14508918 ] 

Lin Chen edited comment on DIRKRB-229 at 4/23/15 11:59 AM:
-----------------------------------------------------------

Hi Yaning, some questions:
1. The javadoc of {{getIdentities()}} said the principal names is ordered by alphabetical order, while in {{JsonIdentityBackend}}, the principal names is ordered by the sequence of adding, maybe it should be sorted before returned.
2. Get identities from map, maybe the codes below will be better?
{code}
public List<String> getIdentities() {
      return new ArrayList<>(ids.keySet());
}
{code}
3. In the code: {{System.out.println( principalName)}}, you will print the result like:
{code}
[test1@TEST.COM, test2@TEST.COM, test3@TEST.COM, test4@TEST.COM]
{code}
I am not sure whether it is better to print them by many lines like below:
{code}
test1@TEST.COM
test2@TEST.COM
test3@TEST.COM
test4@TEST.COM
{code}
4. A minor question: In {{List<String> principalName}}, maybe {{principalNames}} will be better?


was (Author: hazelc):
Hi Yaning, some questions:
1. The javadoc of {{getIdentities()}} said the principal names is ordered by alphabetical order, while in {{JsonIdentityBackend}}, the principal names is ordered by the sequence of adding, maybe it should be sorted before returned.
2. Get identities from map, maybe the codes below will be better?
{code}
public List<String> getIdentities() {
      return new ArrayList<>(ids.keySet());
}
{code}
3. In the code: {{System.out.println( principalName)}}, you will print the result like:
{code}
[test1@TEST.COM, test2@TEST.COM, test3@TEST.COM, test4@TEST.COM]
{code}
I am not sure whether it is better to print them by many lines like below:
{code}
test1@TEST.COM
test2@TEST.COM
test3@TEST.COM
test4@TEST.COM
{code}
4. A minor questions: In {{List<String> principalName}}, maybe {{principalNames}} will be better?

> Enhance kadmin to support list principals
> -----------------------------------------
>
>                 Key: DIRKRB-229
>                 URL: https://issues.apache.org/jira/browse/DIRKRB-229
>             Project: Directory Kerberos
>          Issue Type: New Feature
>            Reporter: Jiajia Li
>            Assignee: Xu Yaning
>         Attachments: DIRKRB-229-v1.patch
>
>
> Enhance kadmin to support list principals.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)