You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/08/31 02:08:49 UTC
[GitHub] [apisix] spacewander commented on a change in pull request #4940: chore(core): delay encode log data and format log
spacewander commented on a change in pull request #4940:
URL: https://github.com/apache/apisix/pull/4940#discussion_r698929414
##########
File path: apisix/core/config_etcd.lua
##########
@@ -181,15 +181,15 @@ local function load_full_data(self, dir_res, headers)
data_valid, err = check_schema(self.item_schema, item.value)
if not data_valid then
log.error("failed to check item data of [", self.key,
- "] err:", err, " ,val: ", json.encode(item.value))
+ "] err:", err, ", val: ", json.delay_encode(item.value))
Review comment:
We don't delay encode for error level log, which is high enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org