You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/04/23 01:39:35 UTC
Review Request 46588: Added URI struct to stout.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46588/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Artem Harutyunyan, Jie Yu, and Jojy Varghese.
Repository: mesos
Description
-------
This will replace the `mesos::URI` protobuf currently used by the `uri::Fetcher`.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/Makefile.am 10be36652034ea5860f122ffb45ee50cc72ffdb3
3rdparty/libprocess/3rdparty/stout/include/Makefile.am 33ddb06e25920096f2d16d4f372129ee2f6a8721
3rdparty/libprocess/3rdparty/stout/include/stout/uri.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/tests/uri_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/46588/diff/
Testing
-------
make check (OSX) GTEST_FILTER="URITest*"
TODO: Run build on a clean environment.
Thanks,
Joseph Wu
Re: Review Request 46588: Added URI struct to stout.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46588/#review130232
-----------------------------------------------------------
Bad patch!
Reviews applied: [46588, 46580]
Failed command: ./support/apply-review.sh -n -r 46588
Error:
2016-04-23 00:39:55 URL:https://reviews.apache.org/r/46588/diff/raw/ [9453/9453] -> "46588.patch" [1]
Total errors found: 0
Checking 2 files
Error: No line in the commit message summary may exceed 72 characters.
Full log: https://builds.apache.org/job/mesos-reviewbot/12678/console
- Mesos ReviewBot
On April 22, 2016, 11:39 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46588/
> -----------------------------------------------------------
>
> (Updated April 22, 2016, 11:39 p.m.)
>
>
> Review request for mesos, Gilbert Song, Artem Harutyunyan, Jie Yu, and Jojy Varghese.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This will replace the `mesos::URI` protobuf currently used by the `uri::Fetcher`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/Makefile.am 10be36652034ea5860f122ffb45ee50cc72ffdb3
> 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 33ddb06e25920096f2d16d4f372129ee2f6a8721
> 3rdparty/libprocess/3rdparty/stout/include/stout/uri.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/tests/uri_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/46588/diff/
>
>
> Testing
> -------
>
> make check (OSX) GTEST_FILTER="URITest*"
>
> TODO: Run build on a clean environment.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 46588: Added URI struct to stout.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46588/
-----------------------------------------------------------
(Updated April 25, 2016, 5:59 p.m.)
Review request for mesos, Gilbert Song, Artem Harutyunyan, Jie Yu, and Jojy Varghese.
Changes
-------
Fixed user_info parsing (which is much more expressive than the previous diff allowed).
Added leading slash for `path`, which is more intuitive.
Added surrounding brackets for IPv6 hosts.
Fixed typo for fragment parsing.
Added a ton of tests.
Bugs: MESOS-5254
https://issues.apache.org/jira/browse/MESOS-5254
Repository: mesos
Description
-------
This will replace the `mesos::URI` protobuf currently used by the
`uri::Fetcher`.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/Makefile.am 08ede41dcedc755933d656de58d93796e657749d
3rdparty/libprocess/3rdparty/stout/include/Makefile.am 33ddb06e25920096f2d16d4f372129ee2f6a8721
3rdparty/libprocess/3rdparty/stout/include/stout/uri.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/tests/uri_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/46588/diff/
Testing
-------
make check (OSX) GTEST_FILTER="URITest*"
Ran a clean build (make check) on:
* Ubuntu 12, 14, 15
* CentOS 6, 7
* Debian 8
Thanks,
Joseph Wu
Re: Review Request 46588: Added URI struct to stout.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46588/
-----------------------------------------------------------
(Updated April 25, 2016, 4:13 p.m.)
Review request for mesos, Gilbert Song, Artem Harutyunyan, Jie Yu, and Jojy Varghese.
Changes
-------
Add roundtrip equality to the test. Handle some nuances in the "path" part of the URI.
Bugs: MESOS-5254
https://issues.apache.org/jira/browse/MESOS-5254
Repository: mesos
Description
-------
This will replace the `mesos::URI` protobuf currently used by the
`uri::Fetcher`.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/Makefile.am 08ede41dcedc755933d656de58d93796e657749d
3rdparty/libprocess/3rdparty/stout/include/Makefile.am 33ddb06e25920096f2d16d4f372129ee2f6a8721
3rdparty/libprocess/3rdparty/stout/include/stout/uri.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/tests/uri_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/46588/diff/
Testing
-------
make check (OSX) GTEST_FILTER="URITest*"
Ran a clean build (make check) on:
* Ubuntu 12, 14, 15
* CentOS 6, 7
* Debian 8
Thanks,
Joseph Wu
Re: Review Request 46588: Added URI struct to stout.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46588/
-----------------------------------------------------------
(Updated April 22, 2016, 5:48 p.m.)
Review request for mesos, Gilbert Song, Artem Harutyunyan, Jie Yu, and Jojy Varghese.
Bugs: MESOS-5254
https://issues.apache.org/jira/browse/MESOS-5254
Repository: mesos
Description
-------
This will replace the `mesos::URI` protobuf currently used by the
`uri::Fetcher`.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/Makefile.am 10be36652034ea5860f122ffb45ee50cc72ffdb3
3rdparty/libprocess/3rdparty/stout/include/Makefile.am 33ddb06e25920096f2d16d4f372129ee2f6a8721
3rdparty/libprocess/3rdparty/stout/include/stout/uri.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/tests/uri_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/46588/diff/
Testing
-------
make check (OSX) GTEST_FILTER="URITest*"
Ran a clean build (make check) on:
* Ubuntu 12, 14, 15
* CentOS 6, 7
* Debian 8
Thanks,
Joseph Wu
Re: Review Request 46588: Added URI struct to stout.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46588/
-----------------------------------------------------------
(Updated April 22, 2016, 5:48 p.m.)
Review request for mesos, Gilbert Song, Artem Harutyunyan, Jie Yu, and Jojy Varghese.
Changes
-------
Updated previous commit, then ran this on a bunch of clean environments.
Repository: mesos
Description (updated)
-------
This will replace the `mesos::URI` protobuf currently used by the
`uri::Fetcher`.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/Makefile.am 10be36652034ea5860f122ffb45ee50cc72ffdb3
3rdparty/libprocess/3rdparty/stout/include/Makefile.am 33ddb06e25920096f2d16d4f372129ee2f6a8721
3rdparty/libprocess/3rdparty/stout/include/stout/uri.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/tests/uri_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/46588/diff/
Testing (updated)
-------
make check (OSX) GTEST_FILTER="URITest*"
Ran a clean build (make check) on:
* Ubuntu 12, 14, 15
* CentOS 6, 7
* Debian 8
Thanks,
Joseph Wu