You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Mohamed Battisha <mb...@yahoo.com> on 2012/03/01 19:13:53 UTC
Review Request: Missing java docs for several methods on ActionXCommand.java
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4072/
-----------------------------------------------------------
Review request for oozie.
Summary
-------
Missing java docs for several methods on ActionXCommand.java
This addresses bug OOZIE-719.
https://issues.apache.org/jira/browse/OOZIE-719
Diffs
-----
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 1295701
Diff: https://reviews.apache.org/r/4072/diff
Testing
-------
no code changes only documentation
Thanks,
Mohamed
Re: Review Request: Missing java docs for several methods on
ActionXCommand.java
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4072/#review5537
-----------------------------------------------------------
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java
<https://reviews.apache.org/r/4072/#comment11958>
Is the indentation incorrect or its just the way how it appears here?
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java
<https://reviews.apache.org/r/4072/#comment11959>
Its better to have javadoc for protected methods also
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java
<https://reviews.apache.org/r/4072/#comment11960>
/**
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java
<https://reviews.apache.org/r/4072/#comment11961>
/**
- Virag
On 2012-03-01 18:13:53, Mohamed Battisha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4072/
> -----------------------------------------------------------
>
> (Updated 2012-03-01 18:13:53)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> Missing java docs for several methods on ActionXCommand.java
>
>
> This addresses bug OOZIE-719.
> https://issues.apache.org/jira/browse/OOZIE-719
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 1295701
>
> Diff: https://reviews.apache.org/r/4072/diff
>
>
> Testing
> -------
>
> no code changes only documentation
>
>
> Thanks,
>
> Mohamed
>
>
Re: Review Request: Missing java docs for several methods on
ActionXCommand.java
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4072/#review5668
-----------------------------------------------------------
Ship it!
+1
- Mohammad
On 2012-03-03 20:59:54, Mohamed Battisha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4072/
> -----------------------------------------------------------
>
> (Updated 2012-03-03 20:59:54)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> Missing java docs for several methods on ActionXCommand.java
>
>
> This addresses bug OOZIE-719.
> https://issues.apache.org/jira/browse/OOZIE-719
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 1296701
>
> Diff: https://reviews.apache.org/r/4072/diff
>
>
> Testing
> -------
>
> no code changes only documentation
>
>
> Thanks,
>
> Mohamed
>
>
Re: Review Request: Missing java docs for several methods on
ActionXCommand.java
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4072/#review5616
-----------------------------------------------------------
Ship it!
- Virag
On 2012-03-03 20:59:54, Mohamed Battisha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4072/
> -----------------------------------------------------------
>
> (Updated 2012-03-03 20:59:54)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> Missing java docs for several methods on ActionXCommand.java
>
>
> This addresses bug OOZIE-719.
> https://issues.apache.org/jira/browse/OOZIE-719
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 1296701
>
> Diff: https://reviews.apache.org/r/4072/diff
>
>
> Testing
> -------
>
> no code changes only documentation
>
>
> Thanks,
>
> Mohamed
>
>
Re: Review Request: Missing java docs for several methods on
ActionXCommand.java
Posted by Mohamed Battisha <mb...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4072/
-----------------------------------------------------------
(Updated 2012-03-03 20:59:54.960684)
Review request for oozie.
Changes
-------
adding javadocs for protected member as well
Summary
-------
Missing java docs for several methods on ActionXCommand.java
This addresses bug OOZIE-719.
https://issues.apache.org/jira/browse/OOZIE-719
Diffs (updated)
-----
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 1296701
Diff: https://reviews.apache.org/r/4072/diff
Testing
-------
no code changes only documentation
Thanks,
Mohamed