You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/02/10 07:19:49 UTC

[GitHub] [arrow] Dandandan commented on a change in pull request #9456: ARROW-11574: [Rust][DataFusion] Upgrade sqlparser to support parsing all TPC-H queries

Dandandan commented on a change in pull request #9456:
URL: https://github.com/apache/arrow/pull/9456#discussion_r573497389



##########
File path: rust/benchmarks/src/bin/tpch.rs
##########
@@ -386,7 +386,7 @@ fn create_logical_plan(ctx: &mut ExecutionContext, query: usize) -> Result<Logic
         //     where
         //         l_shipdate >= date '1994-01-01'
         //         and l_shipdate < date '1994-01-01' + interval '1' year
-        //         and l_discount between 0.06 - 0.01 and 0.06 + 0.01
+        //         and l_discount between .06 - 0.01 and .06 + 0.01

Review comment:
       Hm weird. I generated the queries some time ago in here: https://github.com/ballista-compute/sqlparser-rs/tree/main/tests/queries/tpch . maybe the code to generate the queries has been changed slightly




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org