You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/07/15 06:44:40 UTC

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1845: remove not used plugin heartbeat.lua

membphis commented on a change in pull request #1845:
URL: https://github.com/apache/incubator-apisix/pull/1845#discussion_r454827208



##########
File path: conf/config.yaml
##########
@@ -16,7 +16,7 @@
 #
 apisix:
   node_listen: 9080              # APISIX listening port
-  enable_heartbeat: true
+  enable_heartbeat: false

Review comment:
       we need to remove this line.
   
   some code we need to remove too: 
   
   https://github.com/apache/incubator-apisix/search?p=2&q=enable_heartbeat&unscoped_q=enable_heartbeat




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org