You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ferenc-csaky (via GitHub)" <gi...@apache.org> on 2025/10/26 05:14:17 UTC
[PR] [FLINK-38545] Update to Flink 1.20 and Pulsar 3.0.2 with callbacks [flink-connector-pulsar]
ferenc-csaky opened a new pull request, #111:
URL: https://github.com/apache/flink-connector-pulsar/pull/111
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38545] Update to Flink 1.20.3 and Pulsar 3.0.5 [flink-connector-pulsar]
Posted by "ferenc-csaky (via GitHub)" <gi...@apache.org>.
ferenc-csaky commented on code in PR #111:
URL: https://github.com/apache/flink-connector-pulsar/pull/111#discussion_r2466416862
##########
flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/config/SourceConfiguration.java:
##########
@@ -136,7 +137,7 @@ public long getAutoCommitCursorInterval() {
* messages in {@link RecordsWithSplitIds} when meet this timeout and no message consumed.
*/
public int getFetchOneMessageTime() {
- return fetchOneMessageTime;
+ return (int) fetchOneMessageTime;
Review Comment:
Good catch. Cannot do much about this, as the pulsar client requires an `int` value for this, and `Duration.toMillis()` return a `long`. I don't think there can be any case, where someone types in a duration that turns into a bigger number than `Integer.MAX_VALUE`. Since I can type in durations like `5d`, having an explicit check that says you need to type in a lower number than `2147483647` would be more helpful than the cast exception.
Well, we could leave this as an `int`, but it is much better UX to be able to write duration strings than raw millis, so I would consider the current state better then it was before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38545] Update to Flink 1.20.3 and Pulsar 3.0.5 [flink-connector-pulsar]
Posted by "ferenc-csaky (via GitHub)" <gi...@apache.org>.
ferenc-csaky merged PR #111:
URL: https://github.com/apache/flink-connector-pulsar/pull/111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38545] Update to Flink 1.20 and Pulsar 3.0.2 with callbacks [flink-connector-pulsar]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #111:
URL: https://github.com/apache/flink-connector-pulsar/pull/111#issuecomment-3448024656
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38545] Update to Flink 1.20.3 and Pulsar 3.0.5 [flink-connector-pulsar]
Posted by "Poorvankbhatia (via GitHub)" <gi...@apache.org>.
Poorvankbhatia commented on code in PR #111:
URL: https://github.com/apache/flink-connector-pulsar/pull/111#discussion_r2466345459
##########
flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/config/SourceConfiguration.java:
##########
@@ -136,7 +137,7 @@ public long getAutoCommitCursorInterval() {
* messages in {@link RecordsWithSplitIds} when meet this timeout and no message consumed.
*/
public int getFetchOneMessageTime() {
- return fetchOneMessageTime;
+ return (int) fetchOneMessageTime;
Review Comment:
nit: The fetchOneMessageTime field is stored as long but cast to int in the getter, can it risk overflow for large Duration values? Should we add: Add validation to reject values > Integer.MAX_VALUE , or can we make this Duration too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38545] Update to Flink 1.20.3 and Pulsar 3.0.5 [flink-connector-pulsar]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #111:
URL: https://github.com/apache/flink-connector-pulsar/pull/111#issuecomment-3452400426
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org