You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by jk...@apache.org on 2018/04/06 12:43:11 UTC
[thrift] branch master updated: update pull request template
This is an automated email from the ASF dual-hosted git repository.
jking pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/thrift.git
The following commit(s) were added to refs/heads/master by this push:
new 10cfd6a update pull request template
10cfd6a is described below
commit 10cfd6a504bec4a9aaca04ed9944d49ecf4ce322
Author: James E. King III <jk...@apache.org>
AuthorDate: Fri Apr 6 08:43:04 2018 -0400
update pull request template
---
pull_request_template.md | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/pull_request_template.md b/pull_request_template.md
index 5c714bc..2a18207 100644
--- a/pull_request_template.md
+++ b/pull_request_template.md
@@ -1,17 +1,17 @@
#### Instructions for Apache Thrift Pull Requests ####
-1. All code changes require an [Apache Jira THRIFT Issue](http://issues.apache.org/jira/browse/THRIFT) ticket.
-
-1. All pull requests should contain a single commit per issue, or we will ask you to squash it.
-1. The pull request title must begin with the Jira THRIFT ticket identifier, for example:
+* All code changes require an Apache Jira THRIFT Issue
+ (http://issues.apache.org/jira/browse/THRIFT)
+* Pull requests should contain a single commit per issue, or we will ask you to squash it.
+* The pull request title must begin with the Jira THRIFT ticket identifier, for example:
THRIFT-9999: an example pull request title
-1. Commit messages must follow this pattern for code changes (deviations will not be merged):
+* Commit messages must follow this pattern for code changes (deviations will not be merged):
THRIFT-9999: [summary of fix, one line if possible]
Client: [language(s) affected, comma separated, use lib/ directory names please]
-1. Remove these instructions from any pull request description.
+* Remove these instructions from any pull request description.
-For more information about committing, see [CONTRIBUTING](CONTRIBUTING.md).
\ No newline at end of file
+For more information about committing, see CONTRIBUTING.md
--
To stop receiving notification emails like this one, please contact
jking@apache.org.