You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "vishwajeetfr (via GitHub)" <gi...@apache.org> on 2023/11/12 12:27:19 UTC

[PR] BEAM-13612: This will fix the NPE because of absence of the projectId [beam]

vishwajeetfr opened a new pull request, #29409:
URL: https://github.com/apache/beam/pull/29409

   This addresses #21405 NullPointerException because of the projectId's absence picking up the default (or the one provided via BigQueryOptions) project id rather than failing with NPE
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] BEAM-13612: This will fix the NPE because of absence of the projectId [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #29409:
URL: https://github.com/apache/beam/pull/29409#issuecomment-1808588334

   R: @johnjcasey
   
   @vishwajeetfr it looks like several actions checks are failing on the compilation step due to this change (see the checks at the bottom of this PR) - would you mind taking a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] BEAM-13612: This will fix the NPE because of absence of the projectId [beam]

Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey commented on PR #29409:
URL: https://github.com/apache/beam/pull/29409#issuecomment-1816896897

   I now disagree with this change. It appears that all places where we query this value, we check if it's null first. if it is, we default to the .getProject value.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] BEAM-13612: This will fix the NPE because of absence of the projectId [beam]

Posted by "vishwajeetfr (via GitHub)" <gi...@apache.org>.
vishwajeetfr commented on PR #29409:
URL: https://github.com/apache/beam/pull/29409#issuecomment-1807112439

   fixes #29409


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] BEAM-13612: This will fix the NPE because of absence of the projectId [beam]

Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey commented on PR #29409:
URL: https://github.com/apache/beam/pull/29409#issuecomment-1822957509

   This has been resolved with #29471


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] BEAM-13612: This will fix the NPE because of absence of the projectId [beam]

Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey commented on PR #29409:
URL: https://github.com/apache/beam/pull/29409#issuecomment-1814789442

   Looks like a good change to me. But I agree, it looks like this change breaks a number of checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] BEAM-13612: This will fix the NPE because of absence of the projectId [beam]

Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey commented on PR #29409:
URL: https://github.com/apache/beam/pull/29409#issuecomment-1816898646

   I think the key is to update in the .getTable instead


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] BEAM-13612: This will fix the NPE because of absence of the projectId [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29409:
URL: https://github.com/apache/beam/pull/29409#issuecomment-1807114301

   Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] BEAM-13612: This will fix the NPE because of absence of the projectId [beam]

Posted by "vishwajeetfr (via GitHub)" <gi...@apache.org>.
vishwajeetfr commented on PR #29409:
URL: https://github.com/apache/beam/pull/29409#issuecomment-1807113982

   R: @slilichenko @damccorm


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] BEAM-13612: This will fix the NPE because of absence of the projectId [beam]

Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey closed pull request #29409: BEAM-13612: This will fix the NPE because of absence of the projectId
URL: https://github.com/apache/beam/pull/29409


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org