[jira] [Work logged] (BEAM-12530) FakePandasObject should handle inline pandas objects

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-12530?focusedWorklogId=652439&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-652439 ]

ASF GitHub Bot logged work on BEAM-12530:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Sep/21 19:29
            Start Date: 17/Sep/21 19:29
    Worklog Time Spent: 10m 
      Work Description: TheNeuralBit commented on pull request #13457:
URL: https://github.com/apache/beam/pull/13457#issuecomment-922030920


   I'm going to revert this, as it's really only beneficial for `pandas_docs_test`, which we don't run continuously (instead relying on `frames_test` and `pandas_doctests_test` for compatibility checks.
   
   Also I don't think this change is actually capturing the `pd.DataFrame({'col': pd.Series(..)})` case I mentioned. For that I think we'd need to modify the `_monkey_patch_type` method, rather than `FakePandasObject`, which is capturing top level functions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 652439)
    Time Spent: 20m  (was: 10m)

> FakePandasObject should handle inline pandas objects
> ----------------------------------------------------
>
>                 Key: BEAM-12530
>                 URL: https://issues.apache.org/jira/browse/BEAM-12530
>             Project: Beam
>          Issue Type: Improvement
>          Components: dsl-dataframe
>            Reporter: Brian Hulette
>            Assignee: Brian Hulette
>            Priority: P2
>              Labels: stale-P2
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently our doctest framework doesn't handle cases like 
> {code:python}
> pd.DataFrame({'col': pd.Series(..)})
> {code} 
> The pd.Series is replaced with a DeferredSeries and passed to {{pd.DataFrame}}. We should make it identify DeferredBase instances in the args and replace them with their original value.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)