You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "maedhroz (via GitHub)" <gi...@apache.org> on 2023/10/19 21:44:44 UTC

[PR] CASSANDRA-18896 ClientRequestSize metrics should not treat CONTAINS restrictions as being equality-based [cassandra]

maedhroz opened a new pull request, #2829:
URL: https://github.com/apache/cassandra/pull/2829

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSANDRA-18896 ClientRequestSize metrics should not treat CONTAINS restrictions as being equality-based [cassandra]

Posted by "maedhroz (via GitHub)" <gi...@apache.org>.
maedhroz commented on PR #2829:
URL: https://github.com/apache/cassandra/pull/2829#issuecomment-1785910052

   https://github.com/apache/cassandra/commit/256e39fc62c0b0ce576fd29849672e6323eecea4


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSANDRA-18896 ClientRequestSize metrics should not treat CONTAINS restrictions as being equality-based [cassandra]

Posted by "maedhroz (via GitHub)" <gi...@apache.org>.
maedhroz commented on code in PR #2829:
URL: https://github.com/apache/cassandra/pull/2829#discussion_r1367447339


##########
test/unit/org/apache/cassandra/metrics/ClientRequestRowAndColumnMetricsTest.java:
##########
@@ -620,6 +620,6 @@ public void shouldRecordReadMetricsForContainsQuery() throws Throwable
 
         assertEquals(1, ClientRequestSizeMetrics.totalRowsRead.getCount());
         // The filtering term is provided by the client in the request, so we don't consider that column read.

Review Comment:
   Will fix this comment on commit...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSANDRA-18896 ClientRequestSize metrics should not treat CONTAINS restrictions as being equality-based [cassandra]

Posted by "maedhroz (via GitHub)" <gi...@apache.org>.
maedhroz commented on PR #2829:
URL: https://github.com/apache/cassandra/pull/2829#issuecomment-1771749599

   https://app.circleci.com/pipelines/github/maedhroz/cassandra/776/workflows/8686837d-d30e-4854-8b7d-8608b2417323


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSANDRA-18896 ClientRequestSize metrics should not treat CONTAINS restrictions as being equality-based [cassandra]

Posted by "maedhroz (via GitHub)" <gi...@apache.org>.
maedhroz closed pull request #2829: CASSANDRA-18896 ClientRequestSize metrics should not treat CONTAINS restrictions as being equality-based
URL: https://github.com/apache/cassandra/pull/2829


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSANDRA-18896 ClientRequestSize metrics should not treat CONTAINS restrictions as being equality-based [cassandra]

Posted by "maedhroz (via GitHub)" <gi...@apache.org>.
maedhroz commented on PR #2829:
URL: https://github.com/apache/cassandra/pull/2829#issuecomment-1773328235

   Circle run looks clean


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org