Re: [PR] Cleaning replication delay metrics on cleanupMetrics [pinot]

["gortiz (via GitHub)" <gi...@apache.org>]

gortiz commented on PR #12343:
URL: https://github.com/apache/pinot/pull/12343#issuecomment-1920659084

   > When segment is dropped from server (due to rebalance or segment removal), TableDataManager.onConsumingToDropped() will be invoked via the helix state transition from CONSUMING to DROPPED. IMO the real problem is the ordering of invoking this callback and offloading the segment.
   
   I've added a breakpoint and I'm almost 100% the method was not called. I said almost because given there were threads participating, it I may have missed some of them passing through some breakpoint. I can try to replicate it again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org