You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/15 00:24:36 UTC
[GitHub] apeforest opened a new pull request #12174: [MXNET-806] Report
error when shape mismatch in "where" operator
apeforest opened a new pull request #12174: [MXNET-806] Report error when shape mismatch in "where" operator
URL: https://github.com/apache/incubator-mxnet/pull/12174
## Description ##
```mx.sym.where(cond, x, y)``` still functions, given shape-mismatched cond, whereas ```mx.nd.where(cond, x, y)``` will throw exception. We should make sure the behavior is the same.
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [X] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
- [X] Changes are complete (i.e. I finished coding on this PR)
- [X] All changes have test coverage:
- Unit tests are added for small changes to verify correctness
test_operator.py:test_where():test_invalid_shape()
- [ ] Code is well-documented:
- This change is consistent with the current API documentation. Therefore, no additional documentation should be needed.
- Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [X] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [X] where operator with mismatched shape should throw exception
## Comments ##
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services