You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/06/06 19:05:01 UTC
[kudu-CR] rpc-test: deflake TestClientConnectionMetrics
Hello Will Berkeley, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13543
to review the following change.
Change subject: rpc-test: deflake TestClientConnectionMetrics
......................................................................
rpc-test: deflake TestClientConnectionMetrics
Looks like send_bytes_per_sec can overflow:
/home/jenkins-slave/workspace/kudu-master/2/src/kudu/rpc/rpc-test.cc:552
Expected: (conn.socket_stats().send_bytes_per_sec()) > (0), actual: -800244607 vs 0
The code in 'ss' (which inspired this calculation) uses double arithmetic,
but we'll settle for int64, which should be good enough.
Change-Id: I705711a53a6b588c4c164990506c530c8bd6116f
---
M src/kudu/rpc/rpc_introspection.proto
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/13543/1
--
To view, visit http://gerrit.cloudera.org:8080/13543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I705711a53a6b588c4c164990506c530c8bd6116f
Gerrit-Change-Number: 13543
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] rpc-test: deflake TestClientConnectionMetrics
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13543 )
Change subject: rpc-test: deflake TestClientConnectionMetrics
......................................................................
rpc-test: deflake TestClientConnectionMetrics
Looks like send_bytes_per_sec can overflow:
/home/jenkins-slave/workspace/kudu-master/2/src/kudu/rpc/rpc-test.cc:552
Expected: (conn.socket_stats().send_bytes_per_sec()) > (0), actual: -800244607 vs 0
The code in 'ss' (which inspired this calculation) uses double arithmetic,
but we'll settle for int64, which should be good enough.
Change-Id: I705711a53a6b588c4c164990506c530c8bd6116f
Reviewed-on: http://gerrit.cloudera.org:8080/13543
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/rpc/rpc_introspection.proto
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Adar Dembo: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I705711a53a6b588c4c164990506c530c8bd6116f
Gerrit-Change-Number: 13543
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] rpc-test: deflake TestClientConnectionMetrics
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13543 )
Change subject: rpc-test: deflake TestClientConnectionMetrics
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I705711a53a6b588c4c164990506c530c8bd6116f
Gerrit-Change-Number: 13543
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 06 Jun 2019 19:52:28 +0000
Gerrit-HasComments: No
[kudu-CR] rpc-test: deflake TestClientConnectionMetrics
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13543 )
Change subject: rpc-test: deflake TestClientConnectionMetrics
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I705711a53a6b588c4c164990506c530c8bd6116f
Gerrit-Change-Number: 13543
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] rpc-test: deflake TestClientConnectionMetrics
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13543 )
Change subject: rpc-test: deflake TestClientConnectionMetrics
......................................................................
Patch Set 1: Verified+1
Overriding Jenkins, unrelated test flake.
--
To view, visit http://gerrit.cloudera.org:8080/13543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I705711a53a6b588c4c164990506c530c8bd6116f
Gerrit-Change-Number: 13543
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 06 Jun 2019 20:23:01 +0000
Gerrit-HasComments: No