You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by gi...@git.apache.org on 2017/09/06 19:20:19 UTC

[GitHub] jessealva commented on a change in pull request #2675: Added changes for classes and variables casing to be get exported and can be used in other places

jessealva commented on a change in pull request #2675: Added changes for classes and variables casing to be get exported and can be used in other places
URL: https://github.com/apache/incubator-openwhisk/pull/2675#discussion_r137365274
 
 

 ##########
 File path: tools/cli/go-whisk-cli/commands/qualified_name.go
 ##########
 @@ -28,7 +28,7 @@ type QualifiedName struct {
     namespace   string  // namespace. does not include leading '/'.  may be "" (i.e. default namespace)
     packageName string  // package.  may be "".  does not include leading/trailing '/'
     entity      string  // entity.  should not be ""
-    entityName  string  // pkg+entity
+    EntityName  string  // pkg+entity
 
 Review comment:
   @dubeejw This was needed in code in another repo where we do an http call for getting/updating an Action. Based on existing code here, the call to the REST method is made with the `EntityName` of a QualifiedName struct.  Since this are private to this repo, I was not able to use it. Was not trying to duplicate code which creates the QualifiedName struct or how the REST calls are made.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services