You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by kxepal <gi...@git.apache.org> on 2015/10/27 22:01:13 UTC
[GitHub] couchdb-chttpd pull request: Update /_replicate handler and clean ...
GitHub user kxepal opened a pull request:
https://github.com/apache/couchdb-chttpd/pull/86
Update /_replicate handler and clean it from legacy decisions
It's not actual anymore to have try/catch around replicate/2 as it never
throws any errors making catch block is actually unreached for
the specified clauses.
We also shouldn't repeat our self in error response rendering here.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kxepal/couchdb-chttpd fix-try-catch-in-replicate
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-chttpd/pull/86.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #86
----
commit 621d84ef3c0266b8228a87909e846c56bf1ee5b2
Author: Alexander Shorin <kx...@apache.org>
Date: 2015-10-27T20:59:03Z
Update /_replicate handler and clean it from legacy decisions
It's not actual anymore to have try/catch around replicate/2 as it never
throws any errors making catch block is actually unreached for
the specified clauses.
We also shouldn't repeat our self in error response rendering here.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: Update /_replicate handler and clean ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-chttpd/pull/86
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: Update /_replicate handler and clean ...
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/86#issuecomment-152186621
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---