[jira] [Commented] (HBASE-17914) Create a new reader instead of cloning a new StoreFile when compaction

["Bhupendra Kumar Jain (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-17914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701850#comment-16701850 ] 

Bhupendra Kumar Jain commented on HBASE-17914:
----------------------------------------------

In {{StoreFileReader}} class , a new parameter {{shared}} is introduced to control stream read / pread. But this parameter is not passed to the co-processor in {{preStoreFileReaderOpen()}}
So co-processor when creating its own StoreFileReader, has not awareness about type of read. Further based on the parameter value, the readCompleted() method in StoreFileReader will close the actual HFile reader and underlying streams.

In one of our scenario, with co-processor returning its own StoreFileReader [shared=false], the scan successfully happens only first time. Next scan operation are resulting in stream closed exception. (I think, this case may happens in phoenix IndexHalfStoreFileReader also if HBase compaction is disabled)

So I think , the new parameter {{shared}} and {{refCount}} should be available to the co-processor

> Create a new reader instead of cloning a new StoreFile when compaction
> ----------------------------------------------------------------------
>
>                 Key: HBASE-17914
>                 URL: https://issues.apache.org/jira/browse/HBASE-17914
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Compaction, regionserver
>    Affects Versions: 2.0.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17914-v1.patch, HBASE-17914-v1.patch, HBASE-17914-v2.patch, HBASE-17914-v3.patch, HBASE-17914.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)