You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/11 16:26:44 UTC
[GitHub] [flink] akalash opened a new pull request, #19702: [FLINK-27031][runtime] Assign even empty old state to the task if the…
akalash opened a new pull request, #19702:
URL: https://github.com/apache/flink/pull/19702
… upstream has output states since the task should be prepared to filter these old incoming states from upstream
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Assigning even empty old state to the task if the upstream has output states since the task should be prepared to filter these old incoming states from upstream
## Brief change log
- *Send empty StateAssignment to the task if the upstream of this task has output states*
## Verifying this change
This change added tests and can be verified as follows:
- *New test were added to StateAssignmentOperationTest*
-
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] akalash commented on pull request #19702: [FLINK-27031][runtime] Assign even empty old state to the task if the…
Posted by GitBox <gi...@apache.org>.
akalash commented on PR #19702:
URL: https://github.com/apache/flink/pull/19702#issuecomment-1164308563
@Myasuka , Would you like to finish the review? Or does it make sense to ask somebody else to join to review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on pull request #19702: [FLINK-27031][runtime] Assign even empty old state to the task if the…
Posted by GitBox <gi...@apache.org>.
Myasuka commented on PR #19702:
URL: https://github.com/apache/flink/pull/19702#issuecomment-1164319427
@akalash Sorry for the late reply and thanks for your reminder.
I just feel that the logic is a bit too long, and I am +0 for this change. I think you can ask somebody else, e.g. Piotr or Roman to continue this review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] akalash commented on pull request #19702: [FLINK-27031][runtime] Assign even empty old state to the task if the…
Posted by GitBox <gi...@apache.org>.
akalash commented on PR #19702:
URL: https://github.com/apache/flink/pull/19702#issuecomment-1131570424
@Myasuka , yes, you are right I should share my findings in the ticket. I have done it now. So please, take a look at my explanation of this problem (https://issues.apache.org/jira/browse/FLINK-27031). if you still have questions we can continue to discuss it in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] akalash commented on pull request #19702: [FLINK-27031][runtime] Assign even empty old state to the task if the…
Posted by GitBox <gi...@apache.org>.
akalash commented on PR #19702:
URL: https://github.com/apache/flink/pull/19702#issuecomment-1164371478
@Myasuka thanks for your feedback. @pnowojski or @rkhachatryan do you have time to take a look at this PR? If so, please, also take a look at the @Myasuka note above(and my answer).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19702: [FLINK-27031][runtime] Assign even empty old state to the task if the…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19702:
URL: https://github.com/apache/flink/pull/19702#issuecomment-1123994269
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0432bfea318784015f0d542d8dc5ae411c809013",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0432bfea318784015f0d542d8dc5ae411c809013",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0432bfea318784015f0d542d8dc5ae411c809013 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] akalash commented on pull request #19702: [FLINK-27031][runtime] Assign even empty old state to the task if the…
Posted by GitBox <gi...@apache.org>.
akalash commented on PR #19702:
URL: https://github.com/apache/flink/pull/19702#issuecomment-1137472221
It is not really that way. jobManagerTaskRestore -> InflightDataRescalingDescriptor -> Virtual Channel is the current logic that says that we need Virtual Channel only if we need rescaling(which is true). I actually haven't changed anything there. And if something changes that the rescaling feature will be entirely broken. But the condition `we need rescaling` is incorrect right now and it is exactly what I have fixed.
So I tried to say that the current problem is not about missing Virtual Channel the current problem is that we determine rescaling incorrectly(we think that we don't want to rescale but in reality we want).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on pull request #19702: [FLINK-27031][runtime] Assign even empty old state to the task if the…
Posted by GitBox <gi...@apache.org>.
Myasuka commented on PR #19702:
URL: https://github.com/apache/flink/pull/19702#issuecomment-1131086668
@akalash since you did not reply in the original ticket, would you please explain why this PR could resolve this problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan merged pull request #19702: [FLINK-27031][runtime] Assign even empty old state to the task if the…
Posted by GitBox <gi...@apache.org>.
rkhachatryan merged PR #19702:
URL: https://github.com/apache/flink/pull/19702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] akalash commented on pull request #19702: [FLINK-27031][runtime] Assign even empty old state to the task if the…
Posted by GitBox <gi...@apache.org>.
akalash commented on PR #19702:
URL: https://github.com/apache/flink/pull/19702#issuecomment-1127444127
@Myasuka , I didn't get your question. This is the fix for FLINK-27031.
By the way, it would be nice if you could review this ticket if you have time for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on pull request #19702: [FLINK-27031][runtime] Assign even empty old state to the task if the…
Posted by GitBox <gi...@apache.org>.
Myasuka commented on PR #19702:
URL: https://github.com/apache/flink/pull/19702#issuecomment-1127334088
Why this PR targets for FLINK-27031?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on pull request #19702: [FLINK-27031][runtime] Assign even empty old state to the task if the…
Posted by GitBox <gi...@apache.org>.
Myasuka commented on PR #19702:
URL: https://github.com/apache/flink/pull/19702#issuecomment-1132637071
I think your solution is valid. However, I think the logic to resolve this problem is a bit not straight forward.
We need to setup the virtual channel <--- we need the non-rescale InflightDataRescalingDescriptor <---- we need to assign `jobManagerTaskRestore` to task. If any logic within the pipeline had changed, this PR would not take effects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org