[PR] Refine unit testing standards and align quality checks [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu opened a new pull request, #40281:
URL: https://github.com/apache/shardingsphere/pull/40281

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Refine unit testing standards and align quality checks [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu merged PR #40281:
URL: https://github.com/apache/shardingsphere/pull/40281


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Refine unit testing standards and align quality checks [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu commented on PR #40281:
URL: https://github.com/apache/shardingsphere/pull/40281#issuecomment-6282255492

   ### Result
   
   Review Result: Mergeable
   No blocking issues or recommended changes remain.
   
   ### Evidence
   
   All 133 validator tests, 260 source-read checks, and two affected semantic cases passed. Complete rule-reference validation and bootstrap validation also passed. Semicolon-terminated clauses are accepted; incorrect wording and punctuation remain rejected. This round preserves the meaning of the coding rules and existing case expectations. Earlier verification was reused only where its relevant inputs remained valid.
   
   Checkstyle and Spotless do not apply to these Python, Markdown, and TOML files. No new files or license changes require RAT.
   
   ### Coverage
   
   Standalone local candidate retaining the original task baseline, 50c103230f79ef1f7d1fc94c598c6796b81c6f57. This round modifies 6 files. The cumulative review also includes 4 previously committed gen-ut files, covering 10 files and 27 changed blocks. Requirements come from the original seven approved changes and the subsequent explicit approval of punctuation corrections and the minimal validator compatibility fix.
   
   The standards, Chinese and English documentation, Skill, scanner, validator, and tests were reviewed for behavior, contracts, testing, and runtime impact. Two consecutive rounds, each with two independent reviewers, reached consistent conclusions after coordinator review. Review-record validation passed, with no unresolved evidence gaps. This conclusion covers code correctness; CI was not reviewed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org