[GitHub] [spark] MaxGekk commented on a change in pull request #28272: [SPARK-31489][SPARK-31488][SQL][test-hive1.2] Translate date values of pushed down filters to `java.sql.Date`

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #28272:
URL: https://github.com/apache/spark/pull/28272#discussion_r411679646



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystTypeConverters.scala
##########
@@ -470,7 +478,10 @@ object CatalystTypeConverters {
    * This method is slow, and for batch conversion you should be using converter
    * produced by createToScalaConverter.
    */
-  def convertToScala(catalystValue: Any, dataType: DataType): Any = {
-    createToScalaConverter(dataType)(catalystValue)
+  def convertToScala(
+      catalystValue: Any,
+      dataType: DataType,
+      useJava8DateTimeApi: Boolean = SQLConf.get.datetimeJava8ApiEnabled): Any = {

Review comment:
       I made a little mistake. Let me revert the last commit, and just remove the default value.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org