[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1190: [CELEBORN-244][IMPROVEMENT] Separate outstandingPushes from outstandingRpcs

["waitinfuture (via GitHub)" <gi...@apache.org>]

waitinfuture commented on code in PR #1190:
URL: https://github.com/apache/incubator-celeborn/pull/1190#discussion_r1092704305


##########
common/src/main/java/org/apache/celeborn/common/network/client/TransportResponseHandler.java:
##########
@@ -184,13 +216,19 @@ public void handle(ResponseMessage message) throws Exception {
       }
     } else if (message instanceof RpcFailure) {
       RpcFailure resp = (RpcFailure) message;
-      RpcResponseCallback listener = outstandingRpcs.get(resp.requestId);
+      RpcResponseCallback listener = outstandingPushes.get(resp.requestId);
       if (listener == null) {
-        logger.warn(
-            "Ignoring response for RPC {} from {} ({}) since it is not outstanding",
-            resp.requestId,
-            NettyUtils.getRemoteAddress(channel),
-            resp.errorString);
+        listener = outstandingRpcs.get(resp.requestId);
+        if (listener == null) {
+          logger.warn(
+              "Ignoring response for RPC {} from {} ({}) since it is not outstanding",
+              resp.requestId,
+              NettyUtils.getRemoteAddress(channel),
+              resp.errorString);
+        } else {
+          outstandingPushes.remove(resp.requestId);
+          listener.onFailure(new RuntimeException(resp.errorString));
+        }
       } else {
         outstandingRpcs.remove(resp.requestId);

Review Comment:
   outstandingRpcs -> outstandingPushes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org