[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #762: Trim property values

[GitBox <gi...@apache.org>]

garydgregory commented on a change in pull request #762:
URL: https://github.com/apache/logging-log4j2/pull/762#discussion_r810156532



##########
File path: log4j-1.2-api/src/main/java/org/apache/log4j/builders/BuilderManager.java
##########
@@ -71,7 +71,7 @@ public Appender parseAppender(String name, String className, String prefix, Stri
             String filterPrefix, Properties props, PropertiesConfiguration config) {
         Objects.requireNonNull(plugins, "plugins");
         Objects.requireNonNull(className, "className");
-        PluginType<?> plugin = plugins.get(className.toLowerCase());
+        PluginType<?> plugin = plugins.get(className.toLowerCase().trim());

Review comment:
       This could cause an NPE, see the bull check on the line below.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org