You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Raja Aluri (JIRA)" <ji...@apache.org> on 2012/10/12 01:29:03 UTC
[jira] [Created] (HADOOP-8918) devsetup/test-patch.sh is parsing
modified files wrong
Raja Aluri created HADOOP-8918:
----------------------------------
Summary: devsetup/test-patch.sh is parsing modified files wrong
Key: HADOOP-8918
URL: https://issues.apache.org/jira/browse/HADOOP-8918
Project: Hadoop Common
Issue Type: Bug
Components: build
Affects Versions: 2.0.2-alpha
Reporter: Raja Aluri
Fix For: 2.0.3-alpha
devsetup/test-patch.sh is parsing modified files wrong from the patch.
In test-patch.sh script, for running findbugs command, it is trying to find out the modified files by doing the following command
{code}
$GREP '^+++\|^---' $PATCH_DIR/patch | cut -c '5-' | $GREP -v /dev/null | sort | uniq > $TMP
{code}
A patch file can have an entry with xml comments removed, which would match that to be a filename. If you look at the last line of the below text, it would match the filename to be '^M'
{code}
-<?xml version="1.0"?>^M
-<!--^M
- Licensed to the Apache Software Foundation (ASF) under one or more^M- contributor license agreements. See the NOTICE file distributed with^M
- this work for additional information regarding copyright ownership.^M
- The ASF licenses this file to You under the Apache License, Version 2.0^M- (the "License"); you may not use this file except in compliance with^M
- the License. You may obtain a copy of the License at^M
-^M
- http://www.apache.org/licenses/LICENSE-2.0^M
-^M
- Unless required by applicable law or agreed to in writing, software^M
- distributed under the License is distributed on an "AS IS" BASIS,^M
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.^M
- See the License for the specific language governing permissions and^M
- limitations under the License.^M
--->^M
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8918) dev-support/test-patch.sh is parsing
modified files wrong
Posted by "Raja Aluri (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raja Aluri updated HADOOP-8918:
-------------------------------
Summary: dev-support/test-patch.sh is parsing modified files wrong (was: devsetup/test-patch.sh is parsing modified files wrong)
> dev-support/test-patch.sh is parsing modified files wrong
> ---------------------------------------------------------
>
> Key: HADOOP-8918
> URL: https://issues.apache.org/jira/browse/HADOOP-8918
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 2.0.2-alpha
> Reporter: Raja Aluri
> Fix For: 2.0.3-alpha
>
>
> devsetup/test-patch.sh is parsing modified files wrong from the patch.
> In test-patch.sh script, for running findbugs command, it is trying to find out the modified files by doing the following command
> {code}
> $GREP '^+++\|^---' $PATCH_DIR/patch | cut -c '5-' | $GREP -v /dev/null | sort | uniq > $TMP
> {code}
> A patch file can have an entry with xml comments removed, which would match that to be a filename. If you look at the last line of the below text, it would match the filename to be '^M'
> {code}
> -<?xml version="1.0"?>^M
> -<!--^M
> - Licensed to the Apache Software Foundation (ASF) under one or more^M- contributor license agreements. See the NOTICE file distributed with^M
> - this work for additional information regarding copyright ownership.^M
> - The ASF licenses this file to You under the Apache License, Version 2.0^M- (the "License"); you may not use this file except in compliance with^M
> - the License. You may obtain a copy of the License at^M
> -^M
> - http://www.apache.org/licenses/LICENSE-2.0^M
> -^M
> - Unless required by applicable law or agreed to in writing, software^M
> - distributed under the License is distributed on an "AS IS" BASIS,^M
> - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.^M
> - See the License for the specific language governing permissions and^M
> - limitations under the License.^M
> --->^M
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8918) dev-support/test-patch.sh is parsing
modified files wrong
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-8918:
------------------------------------
Resolution: Fixed
Fix Version/s: (was: 2.0.3-alpha)
3.0.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
I committed this patch to trunk. Since Jenkins does not run on branch-2, I am just leaving this change in trunk.
Thank you Raja.
> dev-support/test-patch.sh is parsing modified files wrong
> ---------------------------------------------------------
>
> Key: HADOOP-8918
> URL: https://issues.apache.org/jira/browse/HADOOP-8918
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 2.0.2-alpha
> Reporter: Raja Aluri
> Assignee: Raja Aluri
> Fix For: 3.0.0
>
> Attachments: HADOOP-8918.trunk.patch
>
>
> dev-support/test-patch.sh is parsing modified files wrong from the patch.
> In test-patch.sh script, for running findbugs command, it is trying to find out the modified files by doing the following command
> {code}
> $GREP '^+++\|^---' $PATCH_DIR/patch | cut -c '5-' | $GREP -v /dev/null | sort | uniq > $TMP
> {code}
> A patch file can have an entry with xml comments removed, which would match that to be a filename. If you look at the last line of the below text, it would match the filename to be '^M'
> {code}
> -<?xml version="1.0"?>^M
> -<!--^M
> - Licensed to the Apache Software Foundation (ASF) under one or more^M- contributor license agreements. See the NOTICE file distributed with^M
> - this work for additional information regarding copyright ownership.^M
> - The ASF licenses this file to You under the Apache License, Version 2.0^M- (the "License"); you may not use this file except in compliance with^M
> - the License. You may obtain a copy of the License at^M
> -^M
> - http://www.apache.org/licenses/LICENSE-2.0^M
> -^M
> - Unless required by applicable law or agreed to in writing, software^M
> - distributed under the License is distributed on an "AS IS" BASIS,^M
> - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.^M
> - See the License for the specific language governing permissions and^M
> - limitations under the License.^M
> --->^M
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8918) dev-support/test-patch.sh is
parsing modified files wrong
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474971#comment-13474971 ]
Hudson commented on HADOOP-8918:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #1193 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1193/])
HADOOP-8918. test-patch.sh is parsing modified files wrong. Contributed by Raja Aluri. (Revision 1397411)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397411
Files :
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> dev-support/test-patch.sh is parsing modified files wrong
> ---------------------------------------------------------
>
> Key: HADOOP-8918
> URL: https://issues.apache.org/jira/browse/HADOOP-8918
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 2.0.2-alpha
> Reporter: Raja Aluri
> Assignee: Raja Aluri
> Fix For: 3.0.0
>
> Attachments: HADOOP-8918.trunk.patch
>
>
> dev-support/test-patch.sh is parsing modified files wrong from the patch.
> In test-patch.sh script, for running findbugs command, it is trying to find out the modified files by doing the following command
> {code}
> $GREP '^+++\|^---' $PATCH_DIR/patch | cut -c '5-' | $GREP -v /dev/null | sort | uniq > $TMP
> {code}
> A patch file can have an entry with xml comments removed, which would match that to be a filename. If you look at the last line of the below text, it would match the filename to be '^M'
> {code}
> -<?xml version="1.0"?>^M
> -<!--^M
> - Licensed to the Apache Software Foundation (ASF) under one or more^M- contributor license agreements. See the NOTICE file distributed with^M
> - this work for additional information regarding copyright ownership.^M
> - The ASF licenses this file to You under the Apache License, Version 2.0^M- (the "License"); you may not use this file except in compliance with^M
> - the License. You may obtain a copy of the License at^M
> -^M
> - http://www.apache.org/licenses/LICENSE-2.0^M
> -^M
> - Unless required by applicable law or agreed to in writing, software^M
> - distributed under the License is distributed on an "AS IS" BASIS,^M
> - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.^M
> - See the License for the specific language governing permissions and^M
> - limitations under the License.^M
> --->^M
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8918) dev-support/test-patch.sh is parsing
modified files wrong
Posted by "Raja Aluri (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raja Aluri updated HADOOP-8918:
-------------------------------
Status: Patch Available (was: Open)
I am not sure, how jenkins is going to handle this change, this is changing the bootstrapping/patching code itself. I tested it on my local system, by moving it out of the source tree and calling the test-patch.sh from outside source tree.
> dev-support/test-patch.sh is parsing modified files wrong
> ---------------------------------------------------------
>
> Key: HADOOP-8918
> URL: https://issues.apache.org/jira/browse/HADOOP-8918
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 2.0.2-alpha
> Reporter: Raja Aluri
> Assignee: Raja Aluri
> Fix For: 2.0.3-alpha
>
> Attachments: HADOOP-8918.trunk.patch
>
>
> dev-support/test-patch.sh is parsing modified files wrong from the patch.
> In test-patch.sh script, for running findbugs command, it is trying to find out the modified files by doing the following command
> {code}
> $GREP '^+++\|^---' $PATCH_DIR/patch | cut -c '5-' | $GREP -v /dev/null | sort | uniq > $TMP
> {code}
> A patch file can have an entry with xml comments removed, which would match that to be a filename. If you look at the last line of the below text, it would match the filename to be '^M'
> {code}
> -<?xml version="1.0"?>^M
> -<!--^M
> - Licensed to the Apache Software Foundation (ASF) under one or more^M- contributor license agreements. See the NOTICE file distributed with^M
> - this work for additional information regarding copyright ownership.^M
> - The ASF licenses this file to You under the Apache License, Version 2.0^M- (the "License"); you may not use this file except in compliance with^M
> - the License. You may obtain a copy of the License at^M
> -^M
> - http://www.apache.org/licenses/LICENSE-2.0^M
> -^M
> - Unless required by applicable law or agreed to in writing, software^M
> - distributed under the License is distributed on an "AS IS" BASIS,^M
> - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.^M
> - See the License for the specific language governing permissions and^M
> - limitations under the License.^M
> --->^M
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8918) dev-support/test-patch.sh is parsing
modified files wrong
Posted by "Raja Aluri (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raja Aluri updated HADOOP-8918:
-------------------------------
Attachment: HADOOP-8918.trunk.patch
> dev-support/test-patch.sh is parsing modified files wrong
> ---------------------------------------------------------
>
> Key: HADOOP-8918
> URL: https://issues.apache.org/jira/browse/HADOOP-8918
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 2.0.2-alpha
> Reporter: Raja Aluri
> Assignee: Raja Aluri
> Fix For: 2.0.3-alpha
>
> Attachments: HADOOP-8918.trunk.patch
>
>
> dev-support/test-patch.sh is parsing modified files wrong from the patch.
> In test-patch.sh script, for running findbugs command, it is trying to find out the modified files by doing the following command
> {code}
> $GREP '^+++\|^---' $PATCH_DIR/patch | cut -c '5-' | $GREP -v /dev/null | sort | uniq > $TMP
> {code}
> A patch file can have an entry with xml comments removed, which would match that to be a filename. If you look at the last line of the below text, it would match the filename to be '^M'
> {code}
> -<?xml version="1.0"?>^M
> -<!--^M
> - Licensed to the Apache Software Foundation (ASF) under one or more^M- contributor license agreements. See the NOTICE file distributed with^M
> - this work for additional information regarding copyright ownership.^M
> - The ASF licenses this file to You under the Apache License, Version 2.0^M- (the "License"); you may not use this file except in compliance with^M
> - the License. You may obtain a copy of the License at^M
> -^M
> - http://www.apache.org/licenses/LICENSE-2.0^M
> -^M
> - Unless required by applicable law or agreed to in writing, software^M
> - distributed under the License is distributed on an "AS IS" BASIS,^M
> - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.^M
> - See the License for the specific language governing permissions and^M
> - limitations under the License.^M
> --->^M
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8918) dev-support/test-patch.sh is
parsing modified files wrong
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474705#comment-13474705 ]
Suresh Srinivas commented on HADOOP-8918:
-----------------------------------------
@Raja, good find.
+1 for the patch.
> dev-support/test-patch.sh is parsing modified files wrong
> ---------------------------------------------------------
>
> Key: HADOOP-8918
> URL: https://issues.apache.org/jira/browse/HADOOP-8918
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 2.0.2-alpha
> Reporter: Raja Aluri
> Assignee: Raja Aluri
> Fix For: 2.0.3-alpha
>
> Attachments: HADOOP-8918.trunk.patch
>
>
> dev-support/test-patch.sh is parsing modified files wrong from the patch.
> In test-patch.sh script, for running findbugs command, it is trying to find out the modified files by doing the following command
> {code}
> $GREP '^+++\|^---' $PATCH_DIR/patch | cut -c '5-' | $GREP -v /dev/null | sort | uniq > $TMP
> {code}
> A patch file can have an entry with xml comments removed, which would match that to be a filename. If you look at the last line of the below text, it would match the filename to be '^M'
> {code}
> -<?xml version="1.0"?>^M
> -<!--^M
> - Licensed to the Apache Software Foundation (ASF) under one or more^M- contributor license agreements. See the NOTICE file distributed with^M
> - this work for additional information regarding copyright ownership.^M
> - The ASF licenses this file to You under the Apache License, Version 2.0^M- (the "License"); you may not use this file except in compliance with^M
> - the License. You may obtain a copy of the License at^M
> -^M
> - http://www.apache.org/licenses/LICENSE-2.0^M
> -^M
> - Unless required by applicable law or agreed to in writing, software^M
> - distributed under the License is distributed on an "AS IS" BASIS,^M
> - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.^M
> - See the License for the specific language governing permissions and^M
> - limitations under the License.^M
> --->^M
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8918) dev-support/test-patch.sh is
parsing modified files wrong
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474997#comment-13474997 ]
Hudson commented on HADOOP-8918:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #1224 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1224/])
HADOOP-8918. test-patch.sh is parsing modified files wrong. Contributed by Raja Aluri. (Revision 1397411)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397411
Files :
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> dev-support/test-patch.sh is parsing modified files wrong
> ---------------------------------------------------------
>
> Key: HADOOP-8918
> URL: https://issues.apache.org/jira/browse/HADOOP-8918
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 2.0.2-alpha
> Reporter: Raja Aluri
> Assignee: Raja Aluri
> Fix For: 3.0.0
>
> Attachments: HADOOP-8918.trunk.patch
>
>
> dev-support/test-patch.sh is parsing modified files wrong from the patch.
> In test-patch.sh script, for running findbugs command, it is trying to find out the modified files by doing the following command
> {code}
> $GREP '^+++\|^---' $PATCH_DIR/patch | cut -c '5-' | $GREP -v /dev/null | sort | uniq > $TMP
> {code}
> A patch file can have an entry with xml comments removed, which would match that to be a filename. If you look at the last line of the below text, it would match the filename to be '^M'
> {code}
> -<?xml version="1.0"?>^M
> -<!--^M
> - Licensed to the Apache Software Foundation (ASF) under one or more^M- contributor license agreements. See the NOTICE file distributed with^M
> - this work for additional information regarding copyright ownership.^M
> - The ASF licenses this file to You under the Apache License, Version 2.0^M- (the "License"); you may not use this file except in compliance with^M
> - the License. You may obtain a copy of the License at^M
> -^M
> - http://www.apache.org/licenses/LICENSE-2.0^M
> -^M
> - Unless required by applicable law or agreed to in writing, software^M
> - distributed under the License is distributed on an "AS IS" BASIS,^M
> - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.^M
> - See the License for the specific language governing permissions and^M
> - limitations under the License.^M
> --->^M
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8918) dev-support/test-patch.sh is parsing
modified files wrong
Posted by "Raja Aluri (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raja Aluri updated HADOOP-8918:
-------------------------------
Description:
dev-setup/test-patch.sh is parsing modified files wrong from the patch.
In test-patch.sh script, for running findbugs command, it is trying to find out the modified files by doing the following command
{code}
$GREP '^+++\|^---' $PATCH_DIR/patch | cut -c '5-' | $GREP -v /dev/null | sort | uniq > $TMP
{code}
A patch file can have an entry with xml comments removed, which would match that to be a filename. If you look at the last line of the below text, it would match the filename to be '^M'
{code}
-<?xml version="1.0"?>^M
-<!--^M
- Licensed to the Apache Software Foundation (ASF) under one or more^M- contributor license agreements. See the NOTICE file distributed with^M
- this work for additional information regarding copyright ownership.^M
- The ASF licenses this file to You under the Apache License, Version 2.0^M- (the "License"); you may not use this file except in compliance with^M
- the License. You may obtain a copy of the License at^M
-^M
- http://www.apache.org/licenses/LICENSE-2.0^M
-^M
- Unless required by applicable law or agreed to in writing, software^M
- distributed under the License is distributed on an "AS IS" BASIS,^M
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.^M
- See the License for the specific language governing permissions and^M
- limitations under the License.^M
--->^M
{code}
was:
devsetup/test-patch.sh is parsing modified files wrong from the patch.
In test-patch.sh script, for running findbugs command, it is trying to find out the modified files by doing the following command
{code}
$GREP '^+++\|^---' $PATCH_DIR/patch | cut -c '5-' | $GREP -v /dev/null | sort | uniq > $TMP
{code}
A patch file can have an entry with xml comments removed, which would match that to be a filename. If you look at the last line of the below text, it would match the filename to be '^M'
{code}
-<?xml version="1.0"?>^M
-<!--^M
- Licensed to the Apache Software Foundation (ASF) under one or more^M- contributor license agreements. See the NOTICE file distributed with^M
- this work for additional information regarding copyright ownership.^M
- The ASF licenses this file to You under the Apache License, Version 2.0^M- (the "License"); you may not use this file except in compliance with^M
- the License. You may obtain a copy of the License at^M
-^M
- http://www.apache.org/licenses/LICENSE-2.0^M
-^M
- Unless required by applicable law or agreed to in writing, software^M
- distributed under the License is distributed on an "AS IS" BASIS,^M
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.^M
- See the License for the specific language governing permissions and^M
- limitations under the License.^M
--->^M
{code}
> dev-support/test-patch.sh is parsing modified files wrong
> ---------------------------------------------------------
>
> Key: HADOOP-8918
> URL: https://issues.apache.org/jira/browse/HADOOP-8918
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 2.0.2-alpha
> Reporter: Raja Aluri
> Fix For: 2.0.3-alpha
>
>
> dev-setup/test-patch.sh is parsing modified files wrong from the patch.
> In test-patch.sh script, for running findbugs command, it is trying to find out the modified files by doing the following command
> {code}
> $GREP '^+++\|^---' $PATCH_DIR/patch | cut -c '5-' | $GREP -v /dev/null | sort | uniq > $TMP
> {code}
> A patch file can have an entry with xml comments removed, which would match that to be a filename. If you look at the last line of the below text, it would match the filename to be '^M'
> {code}
> -<?xml version="1.0"?>^M
> -<!--^M
> - Licensed to the Apache Software Foundation (ASF) under one or more^M- contributor license agreements. See the NOTICE file distributed with^M
> - this work for additional information regarding copyright ownership.^M
> - The ASF licenses this file to You under the Apache License, Version 2.0^M- (the "License"); you may not use this file except in compliance with^M
> - the License. You may obtain a copy of the License at^M
> -^M
> - http://www.apache.org/licenses/LICENSE-2.0^M
> -^M
> - Unless required by applicable law or agreed to in writing, software^M
> - distributed under the License is distributed on an "AS IS" BASIS,^M
> - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.^M
> - See the License for the specific language governing permissions and^M
> - limitations under the License.^M
> --->^M
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8918) dev-support/test-patch.sh is parsing
modified files wrong
Posted by "Raja Aluri (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raja Aluri updated HADOOP-8918:
-------------------------------
Description:
dev-support/test-patch.sh is parsing modified files wrong from the patch.
In test-patch.sh script, for running findbugs command, it is trying to find out the modified files by doing the following command
{code}
$GREP '^+++\|^---' $PATCH_DIR/patch | cut -c '5-' | $GREP -v /dev/null | sort | uniq > $TMP
{code}
A patch file can have an entry with xml comments removed, which would match that to be a filename. If you look at the last line of the below text, it would match the filename to be '^M'
{code}
-<?xml version="1.0"?>^M
-<!--^M
- Licensed to the Apache Software Foundation (ASF) under one or more^M- contributor license agreements. See the NOTICE file distributed with^M
- this work for additional information regarding copyright ownership.^M
- The ASF licenses this file to You under the Apache License, Version 2.0^M- (the "License"); you may not use this file except in compliance with^M
- the License. You may obtain a copy of the License at^M
-^M
- http://www.apache.org/licenses/LICENSE-2.0^M
-^M
- Unless required by applicable law or agreed to in writing, software^M
- distributed under the License is distributed on an "AS IS" BASIS,^M
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.^M
- See the License for the specific language governing permissions and^M
- limitations under the License.^M
--->^M
{code}
was:
dev-setup/test-patch.sh is parsing modified files wrong from the patch.
In test-patch.sh script, for running findbugs command, it is trying to find out the modified files by doing the following command
{code}
$GREP '^+++\|^---' $PATCH_DIR/patch | cut -c '5-' | $GREP -v /dev/null | sort | uniq > $TMP
{code}
A patch file can have an entry with xml comments removed, which would match that to be a filename. If you look at the last line of the below text, it would match the filename to be '^M'
{code}
-<?xml version="1.0"?>^M
-<!--^M
- Licensed to the Apache Software Foundation (ASF) under one or more^M- contributor license agreements. See the NOTICE file distributed with^M
- this work for additional information regarding copyright ownership.^M
- The ASF licenses this file to You under the Apache License, Version 2.0^M- (the "License"); you may not use this file except in compliance with^M
- the License. You may obtain a copy of the License at^M
-^M
- http://www.apache.org/licenses/LICENSE-2.0^M
-^M
- Unless required by applicable law or agreed to in writing, software^M
- distributed under the License is distributed on an "AS IS" BASIS,^M
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.^M
- See the License for the specific language governing permissions and^M
- limitations under the License.^M
--->^M
{code}
> dev-support/test-patch.sh is parsing modified files wrong
> ---------------------------------------------------------
>
> Key: HADOOP-8918
> URL: https://issues.apache.org/jira/browse/HADOOP-8918
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 2.0.2-alpha
> Reporter: Raja Aluri
> Fix For: 2.0.3-alpha
>
>
> dev-support/test-patch.sh is parsing modified files wrong from the patch.
> In test-patch.sh script, for running findbugs command, it is trying to find out the modified files by doing the following command
> {code}
> $GREP '^+++\|^---' $PATCH_DIR/patch | cut -c '5-' | $GREP -v /dev/null | sort | uniq > $TMP
> {code}
> A patch file can have an entry with xml comments removed, which would match that to be a filename. If you look at the last line of the below text, it would match the filename to be '^M'
> {code}
> -<?xml version="1.0"?>^M
> -<!--^M
> - Licensed to the Apache Software Foundation (ASF) under one or more^M- contributor license agreements. See the NOTICE file distributed with^M
> - this work for additional information regarding copyright ownership.^M
> - The ASF licenses this file to You under the Apache License, Version 2.0^M- (the "License"); you may not use this file except in compliance with^M
> - the License. You may obtain a copy of the License at^M
> -^M
> - http://www.apache.org/licenses/LICENSE-2.0^M
> -^M
> - Unless required by applicable law or agreed to in writing, software^M
> - distributed under the License is distributed on an "AS IS" BASIS,^M
> - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.^M
> - See the License for the specific language governing permissions and^M
> - limitations under the License.^M
> --->^M
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HADOOP-8918) dev-support/test-patch.sh is
parsing modified files wrong
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas reassigned HADOOP-8918:
---------------------------------------
Assignee: Raja Aluri
> dev-support/test-patch.sh is parsing modified files wrong
> ---------------------------------------------------------
>
> Key: HADOOP-8918
> URL: https://issues.apache.org/jira/browse/HADOOP-8918
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 2.0.2-alpha
> Reporter: Raja Aluri
> Assignee: Raja Aluri
> Fix For: 2.0.3-alpha
>
>
> dev-support/test-patch.sh is parsing modified files wrong from the patch.
> In test-patch.sh script, for running findbugs command, it is trying to find out the modified files by doing the following command
> {code}
> $GREP '^+++\|^---' $PATCH_DIR/patch | cut -c '5-' | $GREP -v /dev/null | sort | uniq > $TMP
> {code}
> A patch file can have an entry with xml comments removed, which would match that to be a filename. If you look at the last line of the below text, it would match the filename to be '^M'
> {code}
> -<?xml version="1.0"?>^M
> -<!--^M
> - Licensed to the Apache Software Foundation (ASF) under one or more^M- contributor license agreements. See the NOTICE file distributed with^M
> - this work for additional information regarding copyright ownership.^M
> - The ASF licenses this file to You under the Apache License, Version 2.0^M- (the "License"); you may not use this file except in compliance with^M
> - the License. You may obtain a copy of the License at^M
> -^M
> - http://www.apache.org/licenses/LICENSE-2.0^M
> -^M
> - Unless required by applicable law or agreed to in writing, software^M
> - distributed under the License is distributed on an "AS IS" BASIS,^M
> - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.^M
> - See the License for the specific language governing permissions and^M
> - limitations under the License.^M
> --->^M
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8918) dev-support/test-patch.sh is
parsing modified files wrong
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474723#comment-13474723 ]
Hudson commented on HADOOP-8918:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #2851 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2851/])
HADOOP-8918. test-patch.sh is parsing modified files wrong. Contributed by Raja Aluri. (Revision 1397411)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397411
Files :
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> dev-support/test-patch.sh is parsing modified files wrong
> ---------------------------------------------------------
>
> Key: HADOOP-8918
> URL: https://issues.apache.org/jira/browse/HADOOP-8918
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 2.0.2-alpha
> Reporter: Raja Aluri
> Assignee: Raja Aluri
> Fix For: 3.0.0
>
> Attachments: HADOOP-8918.trunk.patch
>
>
> dev-support/test-patch.sh is parsing modified files wrong from the patch.
> In test-patch.sh script, for running findbugs command, it is trying to find out the modified files by doing the following command
> {code}
> $GREP '^+++\|^---' $PATCH_DIR/patch | cut -c '5-' | $GREP -v /dev/null | sort | uniq > $TMP
> {code}
> A patch file can have an entry with xml comments removed, which would match that to be a filename. If you look at the last line of the below text, it would match the filename to be '^M'
> {code}
> -<?xml version="1.0"?>^M
> -<!--^M
> - Licensed to the Apache Software Foundation (ASF) under one or more^M- contributor license agreements. See the NOTICE file distributed with^M
> - this work for additional information regarding copyright ownership.^M
> - The ASF licenses this file to You under the Apache License, Version 2.0^M- (the "License"); you may not use this file except in compliance with^M
> - the License. You may obtain a copy of the License at^M
> -^M
> - http://www.apache.org/licenses/LICENSE-2.0^M
> -^M
> - Unless required by applicable law or agreed to in writing, software^M
> - distributed under the License is distributed on an "AS IS" BASIS,^M
> - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.^M
> - See the License for the specific language governing permissions and^M
> - limitations under the License.^M
> --->^M
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8918) dev-support/test-patch.sh is
parsing modified files wrong
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474696#comment-13474696 ]
Hadoop QA commented on HADOOP-8918:
-----------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12548825/HADOOP-8918.trunk.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1616//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1616//console
This message is automatically generated.
> dev-support/test-patch.sh is parsing modified files wrong
> ---------------------------------------------------------
>
> Key: HADOOP-8918
> URL: https://issues.apache.org/jira/browse/HADOOP-8918
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 2.0.2-alpha
> Reporter: Raja Aluri
> Assignee: Raja Aluri
> Fix For: 2.0.3-alpha
>
> Attachments: HADOOP-8918.trunk.patch
>
>
> dev-support/test-patch.sh is parsing modified files wrong from the patch.
> In test-patch.sh script, for running findbugs command, it is trying to find out the modified files by doing the following command
> {code}
> $GREP '^+++\|^---' $PATCH_DIR/patch | cut -c '5-' | $GREP -v /dev/null | sort | uniq > $TMP
> {code}
> A patch file can have an entry with xml comments removed, which would match that to be a filename. If you look at the last line of the below text, it would match the filename to be '^M'
> {code}
> -<?xml version="1.0"?>^M
> -<!--^M
> - Licensed to the Apache Software Foundation (ASF) under one or more^M- contributor license agreements. See the NOTICE file distributed with^M
> - this work for additional information regarding copyright ownership.^M
> - The ASF licenses this file to You under the Apache License, Version 2.0^M- (the "License"); you may not use this file except in compliance with^M
> - the License. You may obtain a copy of the License at^M
> -^M
> - http://www.apache.org/licenses/LICENSE-2.0^M
> -^M
> - Unless required by applicable law or agreed to in writing, software^M
> - distributed under the License is distributed on an "AS IS" BASIS,^M
> - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.^M
> - See the License for the specific language governing permissions and^M
> - limitations under the License.^M
> --->^M
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8918) dev-support/test-patch.sh is
parsing modified files wrong
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474727#comment-13474727 ]
Hudson commented on HADOOP-8918:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2913 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2913/])
HADOOP-8918. test-patch.sh is parsing modified files wrong. Contributed by Raja Aluri. (Revision 1397411)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397411
Files :
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> dev-support/test-patch.sh is parsing modified files wrong
> ---------------------------------------------------------
>
> Key: HADOOP-8918
> URL: https://issues.apache.org/jira/browse/HADOOP-8918
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 2.0.2-alpha
> Reporter: Raja Aluri
> Assignee: Raja Aluri
> Fix For: 3.0.0
>
> Attachments: HADOOP-8918.trunk.patch
>
>
> dev-support/test-patch.sh is parsing modified files wrong from the patch.
> In test-patch.sh script, for running findbugs command, it is trying to find out the modified files by doing the following command
> {code}
> $GREP '^+++\|^---' $PATCH_DIR/patch | cut -c '5-' | $GREP -v /dev/null | sort | uniq > $TMP
> {code}
> A patch file can have an entry with xml comments removed, which would match that to be a filename. If you look at the last line of the below text, it would match the filename to be '^M'
> {code}
> -<?xml version="1.0"?>^M
> -<!--^M
> - Licensed to the Apache Software Foundation (ASF) under one or more^M- contributor license agreements. See the NOTICE file distributed with^M
> - this work for additional information regarding copyright ownership.^M
> - The ASF licenses this file to You under the Apache License, Version 2.0^M- (the "License"); you may not use this file except in compliance with^M
> - the License. You may obtain a copy of the License at^M
> -^M
> - http://www.apache.org/licenses/LICENSE-2.0^M
> -^M
> - Unless required by applicable law or agreed to in writing, software^M
> - distributed under the License is distributed on an "AS IS" BASIS,^M
> - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.^M
> - See the License for the specific language governing permissions and^M
> - limitations under the License.^M
> --->^M
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8918) dev-support/test-patch.sh is
parsing modified files wrong
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474731#comment-13474731 ]
Hudson commented on HADOOP-8918:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2875 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2875/])
HADOOP-8918. test-patch.sh is parsing modified files wrong. Contributed by Raja Aluri. (Revision 1397411)
Result = FAILURE
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397411
Files :
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> dev-support/test-patch.sh is parsing modified files wrong
> ---------------------------------------------------------
>
> Key: HADOOP-8918
> URL: https://issues.apache.org/jira/browse/HADOOP-8918
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 2.0.2-alpha
> Reporter: Raja Aluri
> Assignee: Raja Aluri
> Fix For: 3.0.0
>
> Attachments: HADOOP-8918.trunk.patch
>
>
> dev-support/test-patch.sh is parsing modified files wrong from the patch.
> In test-patch.sh script, for running findbugs command, it is trying to find out the modified files by doing the following command
> {code}
> $GREP '^+++\|^---' $PATCH_DIR/patch | cut -c '5-' | $GREP -v /dev/null | sort | uniq > $TMP
> {code}
> A patch file can have an entry with xml comments removed, which would match that to be a filename. If you look at the last line of the below text, it would match the filename to be '^M'
> {code}
> -<?xml version="1.0"?>^M
> -<!--^M
> - Licensed to the Apache Software Foundation (ASF) under one or more^M- contributor license agreements. See the NOTICE file distributed with^M
> - this work for additional information regarding copyright ownership.^M
> - The ASF licenses this file to You under the Apache License, Version 2.0^M- (the "License"); you may not use this file except in compliance with^M
> - the License. You may obtain a copy of the License at^M
> -^M
> - http://www.apache.org/licenses/LICENSE-2.0^M
> -^M
> - Unless required by applicable law or agreed to in writing, software^M
> - distributed under the License is distributed on an "AS IS" BASIS,^M
> - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.^M
> - See the License for the specific language governing permissions and^M
> - limitations under the License.^M
> --->^M
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira