You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/10/01 12:26:20 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #7715: Enable avro reading/writing in datafusion-cli
alamb opened a new pull request, #7715:
URL: https://github.com/apache/arrow-datafusion/pull/7715
## Which issue does this PR close?
Closes https://github.com/apache/arrow-datafusion/issues/7714
## Rationale for this change
I would like to have avro support when testing with `datafusion-cli`
## What changes are included in this PR?
1. Enable `avro` support in datafusion-cli
2. Fix typo in `Cargo.toml`
## Are these changes tested?
I tested manually:
Before change:
```
alamb@MacBook-Pro-8:~/Software/arrow-datafusion$ ./datafusion-cli/target/debug/datafusion-cli -c "select * from './testing/data/avro/alltypes_plain.avro';"
DataFusion CLI v31.0.0
Error during planning: table 'datafusion.public../testing/data/avro/alltypes_plain.avro' not found
```
After change:
```
alamb@MacBook-Pro-8:~/Software/arrow-datafusion$ ./datafusion-cli/target/debug/datafusion-cli -c "select * from './testing/data/avro/alltypes_plain.avro';"
DataFusion CLI v31.0.0
+----+----------+-------------+--------------+---------+------------+-----------+------------+------------------+------------+---------------------+
| id | bool_col | tinyint_col | smallint_col | int_col | bigint_col | float_col | double_col | date_string_col | string_col | timestamp_col |
+----+----------+-------------+--------------+---------+------------+-----------+------------+------------------+------------+---------------------+
| 4 | true | 0 | 0 | 0 | 0 | 0.0 | 0.0 | 30332f30312f3039 | 30 | 2009-03-01T00:00:00 |
| 5 | false | 1 | 1 | 1 | 10 | 1.1 | 10.1 | 30332f30312f3039 | 31 | 2009-03-01T00:01:00 |
| 6 | true | 0 | 0 | 0 | 0 | 0.0 | 0.0 | 30342f30312f3039 | 30 | 2009-04-01T00:00:00 |
| 7 | false | 1 | 1 | 1 | 10 | 1.1 | 10.1 | 30342f30312f3039 | 31 | 2009-04-01T00:01:00 |
| 2 | true | 0 | 0 | 0 | 0 | 0.0 | 0.0 | 30322f30312f3039 | 30 | 2009-02-01T00:00:00 |
| 3 | false | 1 | 1 | 1 | 10 | 1.1 | 10.1 | 30322f30312f3039 | 31 | 2009-02-01T00:01:00 |
| 0 | true | 0 | 0 | 0 | 0 | 0.0 | 0.0 | 30312f30312f3039 | 30 | 2009-01-01T00:00:00 |
| 1 | false | 1 | 1 | 1 | 10 | 1.1 | 10.1 | 30312f30312f3039 | 31 | 2009-01-01T00:01:00 |
+----+----------+-------------+--------------+---------+------------+-----------+------------+------------------+------------+---------------------+
8 rows in set. Query took 0.009 seconds.
```
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] sarutak commented on pull request #7715: Enable avro reading/writing in datafusion-cli
Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on PR #7715:
URL: https://github.com/apache/arrow-datafusion/pull/7715#issuecomment-1742072387
@alamb
This looks good to me.
Thank you for enabling Avro for `datafusion-cli` by default!
I usually enabled the feature by `--features datafusion/avro`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable avro reading/writing in datafusion-cli [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #7715:
URL: https://github.com/apache/arrow-datafusion/pull/7715
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable avro reading/writing in datafusion-cli [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #7715:
URL: https://github.com/apache/arrow-datafusion/pull/7715#issuecomment-1744636280
Thank you for the review @yjshen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org