You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jedcunningham (via GitHub)" <gi...@apache.org> on 2023/08/24 22:10:29 UTC

[GitHub] [airflow] jedcunningham commented on pull request #33680: Adding connection-backed Kubernetes Secrets to KubernetesPodOperator

jedcunningham commented on PR #33680:
URL: https://github.com/apache/airflow/pull/33680#issuecomment-1692480479

   It's not a bad idea to make it use the Airflow env var format just for consistency, but not for the "ease of use" with hooks like you are thinking of. KPO typically doesn't run real "Airflow" code, and you need a whole lot more than just some connections to make that work (really need all config, dags, etc) - it needs to look more like a KE worker, which is non-trivial with KPO.
   
   My 2c, making it feel more like other operators where you provide the connection id, and KPO adds the normal `AIRFLOW_CONN_{CONN_ID}` env var is a better authoring experience than trying to mirror the existing secret interface.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org