You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by dw...@apache.org on 2021/03/10 09:45:58 UTC

[lucene] 17/21: more javadocs and class rename

This is an automated email from the ASF dual-hosted git repository.

dweiss pushed a commit to branch jira/solr14155
in repository https://gitbox.apache.org/repos/asf/lucene.git

commit 4803c08f026138e7cb99b486642ec47345a92eda
Author: noble <no...@apache.org>
AuthorDate: Sun Dec 29 11:30:42 2019 +1100

    more javadocs and class rename
---
 .../java/org/apache/solr/pkg/PackageAwareSolrClassLoader.java | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/solr/core/src/java/org/apache/solr/pkg/PackageAwareSolrClassLoader.java b/solr/core/src/java/org/apache/solr/pkg/PackageAwareSolrClassLoader.java
index 5820439..90052e7 100644
--- a/solr/core/src/java/org/apache/solr/pkg/PackageAwareSolrClassLoader.java
+++ b/solr/core/src/java/org/apache/solr/pkg/PackageAwareSolrClassLoader.java
@@ -35,7 +35,7 @@ import org.apache.solr.util.plugin.SolrCoreAware;
 import static java.util.Collections.singletonMap;
 
 /**
- * This class implements a SolrClassLoader that can  identify the correct packages
+ * This class implements a {@link SolrClassLoader} that can  identify the correct packages
  * and load classes from that. This also listens to any changes to the relevant packages and
  * invoke a callback if anything is modified
  */
@@ -51,7 +51,7 @@ public class PackageAwareSolrClassLoader implements SolrClassLoader {
   /**
    *
    * @param core The core where this belong to
-   * @param runnable run a task if somethingis modified, say reload schema or reload core, refresh cache or something else
+   * @param runnable run a task if something is modified, say reload schema or reload core, refresh cache or something else
    */
   public PackageAwareSolrClassLoader(SolrCore core,  Runnable runnable) {
     this.core = core;
@@ -92,7 +92,7 @@ public class PackageAwareSolrClassLoader implements SolrClassLoader {
         loader.registerSolrCoreAware((SolrCoreAware) result);
       }
       classNameVsPkg.put(cname, ver.getVersionInfo());
-      PackageListeners.Listener listener = new SchemaPluginPackageListener(expectedType, cname, parsedClassName);
+      PackageListeners.Listener listener = new PackageListener(expectedType, cname, parsedClassName);
       listeners.add(listener);
       core.getPackageListeners().addListener(listener);
       return result;
@@ -116,16 +116,15 @@ public class PackageAwareSolrClassLoader implements SolrClassLoader {
     for (PackageListeners.Listener l : listeners) {
       core.getPackageListeners().removeListener(l);
     }
-
   }
 
-  private class SchemaPluginPackageListener implements PackageListeners.Listener {
+  private class PackageListener implements PackageListeners.Listener {
 
     private final String cname;
     private final PluginInfo.ParsedClassName parsedClassName;
     PluginInfo info;
 
-    public SchemaPluginPackageListener(Class expectedType, String cname, PluginInfo.ParsedClassName parsedClassName) {
+    public PackageListener(Class expectedType, String cname, PluginInfo.ParsedClassName parsedClassName) {
       this.cname = cname;
       this.parsedClassName = parsedClassName;
       info = new PluginInfo(expectedType.getSimpleName(), singletonMap("class", cname));